[#39161] - Update accessibility plugin to version 4.5.3
- Closed
- 29 Mar 2024
- Medium
- Build: 4.3-dev
- # 39161
- Diff
- drmenzelit:a11y
User tests: Successful: Unsuccessful:
The developer of the accessibility plugin (Ran Buchnik) actualized the code using typescript. In parallel we had a GSoC student working on improvements for the plugin. In the last weeks we were able to put almost all improvements together and the result should now be integrated in Joomla.
Summary of Changes
- Fix: Accessibility plugin is not accessible => Made a11y accessible with keyboard.
- Fix: Plugin System - Additional Accessibility Features is not correctly detected in the page landmarks by Skip To plugin
- Made text-to-speech-language and speech-to-text language change to the currently active language of the site. Default is en-US. If the language is not supported then tts will not be displayed.
- Fixed the italic icons and corrected the emoji for underline link
- Increase / decrease line height
- Pause animations: Added the pause animations button for disabling autoplaying gifs, videos, CSS transitions, and animation.
- Reading velocity
- New feature: change the position of the icon (bottom right, bottom left, top right, top left)
Testing Instructions
- Install this PR and run npm ci or install the package
- Just check that the close and reset icons are not italic anymore and icon for underline links is correct.
- Check that all already existent functions of the plugin are still working.
- Check if you can reach the icon using the keyboard.
- Check the speech velocity.
- Change to a language other than en-US. Check if the voice of the text-to-speech adapts to the site language or not.
If the tts is not displayed then can confirm from here: https://jsbin.com/wuqumukesu/edit?js,console,output
that language is not supported by your browser/os. - Just check you are able to increase/decrease line height. Do not forget to check for persistent session and reset button.
- Make sure that you are able to play/stop gifs, autoplaying videos, CSS transitions and animations by clicking on the "Stop animation" button.
- Check both options: Emojis and Google Material Font
- Play with the position
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings JavaScript Repository NPM Change Front End Plugins |
| Labels |
Added:
Language Change
NPM Resource Changed
PR-4.3-dev
|
||
this needs an update script
and probably more than that... meanwhile there is a new version, some things seems not to be working correctly and I can't follow the code... I will keep the PR as draft until we can resolve the inconsistencies.
surely if things are not working then they should be discussed upstream and not here
or do you mean the joomla integration is not working?
I have created a new PR upstream.
| Title |
|
||||||
| Category | Administration Language & Strings JavaScript Repository NPM Change Front End Plugins | ⇒ | Administration Language & Strings JavaScript Repository SQL Installation Postgresql NPM Change Front End Plugins |
I have been testing the plugin for a while now. My findings:
- 'decrease line height' increases line height, there is no way to decrease line height other than doing a reset
- speech to text/text to speech worked fine on the Edge browser but eventually froze the site and I had to empty the browser's cache to recover from it (not reproduced since).
- text to speech: the beginning of sentences are cut off. It says 'een reader enabled' for instance.
- after switching to French, the voice kept reading in English.
The rest seems to work properly as advertised!
Sorry but this version of the accessibility plugin has many issues which all come from the code contributed upstream.
Hotkeys that worked previously eg ctrl alt c, ctrl alt g no longer work at all
Yes I can reach the icon with the keyboard but its still got an italic which is shown by the outline
As I can no longer use the hotkeys then reaching the icon with my keyboard doesnt help as its not navigable with the keyboard once open
Reading the code I can see an addition which adds english only strings to be used in tts
https://github.com/drmenzelit/accessibility/blob/27f460553e5f4bfa59870611cf2cfc2dfc278609/dist/menu-interface.js#L130
Not only is this english only but it is only for users of the tts engine in this plugin. users of a real screen reader do not benefit from this at all
Check the speech velocity.
Not sure what I was supposed to be testing here. I couldnt find any options.
Perhaps by accident when trying to turn off the tts I discovered that I needed to click it three times while it cycled through the options. ** not something I can do without being able to see and use a mouse **
Also confirm @obuisard finding that the tts missed the beginning of the sentence. It also cuts off before finishing when you are turning it off.
Not sure what I was supposed to be testing here. I couldn't find any options.
There are 3 bars for the velocity (as I understood it), although very narrow and not very visible. By triggering 'Text to speech', it cycles through all speech speeds.
I thought that line was a css bug
Interesting I have very different icons to you
Interesting I have very different icons to you
Now you can switch the icon set in the plugin options
BTW, I have another issue, but I am not sure if this is a feature or a bug:
when using text to speech, links go nowhere, I can only stay on the page. Only once I switch off 'Text to speech' that I can go to another page.
The new line height option does not reset correctly - see video
chrome_2022-11-07_23-09-38.mp4
| Labels |
Added:
a11y
|
||
Inverted colours make color contrast very weak if there is opacity (muted). Inversion is not made in drop downs.
The text to speech causes first a long line at the bottom, clicking several times the line is divided. From above I see that this is spee velocitiy.
I think that this is an UX issue and must be improved.
After installing the patch and running npm ci the following error occurs in the Windows prompt:
Node.js v18.13.0
npm ERR! code 1
npm ERR! path C:\xampp\htdocs\bugtesting5\joomla
npm ERR! command failed
Then I uninstalled the patch and can run npm ci without any problems.
Is there something wrong with this patch?
Thanks for the info. What now?
Thanks for the info. What now?
Find someone who can fix the library... my javascript knowledge is very rudimentary...
This pull request has been automatically rebased to 4.4-dev.
@drmenzelit Probably should close since this will probably not go into v4.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-29 14:58:19 |
| Closed_By | ⇒ | drmenzelit | |
| Labels |
Added:
Conflicting Files
bug
PR-4.4-dev
Removed: PR-4.3-dev |
||
this needs an update script