[#3916] - Comment out opening HTML comment in Javascript tag
- Closed
- 31 Jul 2014
- Medium
- Build: staging
- # 3916
- Diff
- mseymour:patch-1
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
It seems to have been there for a little over a year if not longer.
@test: Failure
1. The PR no longer applies to the current staging branch
2. I think the change is not completely correct because when I look in the source code I see this:
//<!--
document.getElementById('cloak19480').innerHTML = '';
.....
document.getElementById('cloak19480').innerHTML += '<a ' + path + '\'' + prefix + ':' + addy19480 + '\' rel="alternate">'+addy_text19480+'<\/a>';
//-->
I wonder if it shouldn't just be:
<!--
document.getElementById('cloak19480').innerHTML = '';
.....
document.getElementById('cloak19480').innerHTML += '<a ' + path + '\'' + prefix + ':' + addy19480 + '\' rel="alternate">'+addy_text19480+'<\/a>';
-->
As far as I know --> isn't valid Javascript, so it would make sense to comment it out.
At least that's how I've learned it about 10 years ago.
@mseymour and @Kubik-Rubik Thanks for the feedback, TIL today :)
Attempted to fix the PR, although probably because it was originally from infograf it appears to have screwed up. Will try again with a clean pull request.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-31 12:20:02 |
http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_id=8103&tracker_item_id=33958