? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
17 Jul 2014

Inset an image in an article content.
Then add a mail adress to the image.
You will get this

screen shot 2014-07-17 at 10 55 16
What happens is that the < and > are converted to html entities.
This patch should solve it

avatar infograf768 infograf768 - open - 17 Jul 2014
avatar Kubik-Rubik
Kubik-Rubik - comment - 17 Jul 2014

@test Works as advertised. 2 successful tests at JoomlaCode, can be merged.

avatar Kubik-Rubik
Kubik-Rubik - comment - 17 Jul 2014

PS: We have the same issue in the HTML library (libraries/html/email.php).

The convertEncoding function was moved to a wrong position, so that image links are also encoded which leads to the same broken output as described in this PR.

// Convert text - here is the right place
$text = static::convertEncoding($text);

This code section should be placed back in the if($email) statement. PR will follow!

avatar infograf768 infograf768 - reference | 7a57c37 - 17 Jul 14
avatar infograf768 infograf768 - merge - 17 Jul 2014
avatar infograf768 infograf768 - close - 17 Jul 2014
avatar infograf768 infograf768 - change - 17 Jul 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-07-17 14:45:55
avatar infograf768 infograf768 - close - 17 Jul 2014
avatar infograf768 infograf768 - reference | 6ee7466 - 17 Jul 14
avatar infograf768 infograf768 - head_ref_deleted - 12 Aug 2014

Add a Comment

Login with GitHub to post a comment