Feeling Lucky
?
NPM Resource Changed
?
[#39091] - [bug] Do not force value validation (media field)
- Fixed in Code Base
- 29 Oct 2022
- Medium
- Build: 4.2-dev
- # 39091
- Diff
- dgrammatiko:patch-2
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This step is unnecessary and it breaks some 3rd PD adapters
Testing Instructions
- Create a new article
- Select an intro image
- type the same path for the full image
- save the article
- reopen
Everything works
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
viocassel
- comment
- 28 Oct 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39091.
| Status | Pending | ⇒ | Ready to Commit |
laoneo
- comment
- 28 Oct 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39091.
wilsonge
- comment
- 28 Oct 2022
Sorry what validation are we skipping here and why? Breaking 3PDs obviously isn't great. But not really understanding why we're ignoring invalid data
| Labels |
Added:
?
NPM Resource Changed
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-29 15:41:42 |
| Closed_By | ⇒ | fancyFranci |
fancyFranci
- comment
- 29 Oct 2022
Thank you for helping 3rd PD adapters!
I have tested this item✅ successfully on 26176b4
Tested it with the restricted adapter, before the patch it created an url like when saving the article:
Before save:
images/dprestricted/items/com_content.article/1/actions-list.png#joomlaImage://dprestricted-item/actions-list.png?width=1067&height=457
After save:
images/dprestricted/items/com_content.article/1/actions-list.png#joomlaImage://local-images/dprestricted/items/com_content.article/1/actions-list.png?width=1067&height=457
After applying the patch, the urls do look like:
Before save:
images/dprestricted/items/com_content.article/1/actions-list.png#joomlaImage://dprestricted-item/actions-list.png?width=1067&height=457
After save:
images/dprestricted/items/com_content.article/1/actions-list.png#joomlaImage://dprestricted-item/actions-list.png?width=1067&height=457
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39091.