No Code Attached Yet
avatar heelc29
heelc29
25 Oct 2022

JLIB_RULES_SETTING_NOTES_ITEM_COM_CATEGORIES is not used after apply PR #35424

Steps to reproduce the issue

Open category edit form and switch to tab Permissions.

J4.2

image
image

J4.3

image

image

Expected result

Same text as before the PR -> language string from com_categories.ini is used

Actual result

Standard text for components -> language string from lib_joomla.ini is used

System information (as much as possible)

J4.2.4 and J4.3-dev

@wojsmol @HLeithner

avatar heelc29 heelc29 - open - 25 Oct 2022
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 25 Oct 2022
avatar Kostelano
Kostelano - comment - 25 Oct 2022

Missing "section"? In addition to the component, it is also needed.

avatar richard67
richard67 - comment - 13 Nov 2022

Missing "section"? In addition to the component, it is also needed.

Maybe. But the bigger problem is that here we are not in com_categories, we are in com_content. URL is option=com_categories&view=category&layout=edit&id=2&extension=com_content, and it seems the extension parameter is the relevant one.

When I change the language string constant from JLIB_RULES_SETTING_NOTES_ITEM_COM_CATEGORIES to LIB_RULES_SETTING_NOTES_ITEM_COM_CONTENT_CATEGORY, the right test is shown.

Of course we can't just rename that string. We have to deprecate the old one, and I have to check if the same applies to the other string from PR #35424 , too.

avatar richard67
richard67 - comment - 13 Nov 2022

I will make a PR soon.

avatar richard67
richard67 - comment - 13 Nov 2022

The other string JLIB_RULES_SETTING_NOTES_COM_TEMPLATES from PR #35424 is ok.

avatar richard67 richard67 - change - 13 Nov 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-11-13 12:43:44
Closed_By richard67
avatar richard67 richard67 - close - 13 Nov 2022
avatar richard67
richard67 - comment - 13 Nov 2022

Closing as having a pull request. Please test #39212 . Thanks in advance.

Add a Comment

Login with GitHub to post a comment