User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Fix code style errors introduced with release of 4.2.4.
Check drone logs for PHPCS checks.
FILE: .../plugins/system/debug/src/DataCollector/RequestDataCollector.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
24 | WARNING | [ ] Visibility must be declared on all constants if
| | your project supports PHP 7.1 or later
44 | ERROR | [x] Expected 1 space after FUNCTION keyword; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
The error about missing space has gone. The warning about visibility has to be fixed with another PR since there might be more to be fixed.
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Front End Plugins |
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-25 17:25:36 |
Closed_By | ⇒ | richard67 | |
Labels |
Added:
?
|
Hmm, the warning which remains also makes PHPCS fail, so this PR alone will not fix that.