? Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
25 Oct 2022

Pull Request for Issue # .

Summary of Changes

Fix code style errors introduced with release of 4.2.4.

Testing Instructions

Check drone logs for PHPCS checks.

Actual result BEFORE applying this Pull Request

FILE: .../plugins/system/debug/src/DataCollector/RequestDataCollector.php
----------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------
 24 | WARNING | [ ] Visibility must be declared on all constants if
    |         |     your project supports PHP 7.1 or later
 44 | ERROR   | [x] Expected 1 space after FUNCTION keyword; 0 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------

Expected result AFTER applying this Pull Request

The error about missing space has gone. The warning about visibility has to be fixed with another PR since there might be more to be fixed.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar richard67 richard67 - open - 25 Oct 2022
avatar richard67 richard67 - change - 25 Oct 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2022
Category Front End Plugins
avatar richard67
richard67 - comment - 25 Oct 2022

Hmm, the warning which remains also makes PHPCS fail, so this PR alone will not fix that.

avatar richard67 richard67 - close - 25 Oct 2022
avatar richard67 richard67 - change - 25 Oct 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-10-25 17:25:36
Closed_By richard67
Labels Added: ?

Add a Comment

Login with GitHub to post a comment