PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
25 Oct 2022

Summary of Changes

Removes dependency on Factory from the publishing plugin. there should be no impact on the functionality of the plugin

Testing Instructions

Check the publishing plugin continues to inject the javascript into the articles list view when the plugin is enabled. There should be no change in functionality before and after the PR

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar wilsonge wilsonge - open - 25 Oct 2022
avatar wilsonge wilsonge - change - 25 Oct 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2022
Category Front End Plugins
avatar laoneo
laoneo - comment - 26 Oct 2022

It would be cool, when you would directly change the plugin to service provider ?

avatar wilsonge
wilsonge - comment - 26 Oct 2022

Sounds like something for another PR to me ;)

avatar wilsonge wilsonge - change - 27 Oct 2022
Title
Remove dependency on factory
[4.3] Remove dependency on factory
avatar wilsonge wilsonge - edited - 27 Oct 2022
avatar HLeithner HLeithner - change - 27 Oct 2022
Labels Added: PR-4.3-dev
avatar obuisard obuisard - close - 27 Oct 2022
avatar obuisard obuisard - merge - 27 Oct 2022
avatar obuisard obuisard - change - 27 Oct 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-10-27 15:48:46
Closed_By obuisard
avatar obuisard
obuisard - comment - 27 Oct 2022

Thank you George @wilsonge

Add a Comment

Login with GitHub to post a comment