User tests: Successful: Unsuccessful:
Joomla allows to use diffrent primary key names for tables. This has not be honored in the FormView::initializeView()
function.
Load the primary key name from the table provided by the model and use it for the toolbar.
Check if existing edit views makes errors.
if you have a component with a diffrent primary key then 'id' test it.
Most of my components have not id
as primary key and they work now^^
No error for existing View
Doesn't work with the new FormView with primary key different then id
Warning: Undefined property: Joomla\CMS\Object\CMSObject::$id in ROOT/libraries/src/MVC/View/FormView.php on line 147
Warning: Undefined property: Joomla\CMS\Object\CMSObject::$id in ROOT/libraries/src/MVC/View/FormView.php on line 167
Everything works as before
No Warnings and working title and edit button for Views
with diffrent primary key column name then id
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
Labels |
Added:
?
Maintainers Checked
|
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-11-27 22:58:11 |
Closed_By | ⇒ | wilsonge | |
Labels |
Added:
?
|
Thanks!
I have tested this item✅ successfully on da54b0b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/39067.