Language Change NPM Resource Changed Maintainers Checked PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar bembelimen
bembelimen
22 Oct 2022

See #37900 .

Summary of Changes

This PR removed the "Warning! Internet Explorer should not be used for proper operation of the Administrator Backend." message completely from the backend.

Testing Instructions

Code review or check the backend login with brocken CSS

Actual result BEFORE applying this Pull Request

Message is displayed (also if CSS is broken)

Expected result AFTER applying this Pull Request

No message ever

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org: joomla/Manual#51

  • No documentation changes for manual.joomla.org needed

avatar bembelimen bembelimen - open - 22 Oct 2022
avatar bembelimen bembelimen - change - 22 Oct 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Oct 2022
Category Administration Language & Strings Templates (admin) Repository NPM Change
avatar zero-24
zero-24 - comment - 22 Oct 2022

Well even when IE11 is EOL its still used in the wild not sure whether it makes much sense to remove it now. J5 a few months from now would be where i would remove such a message as that is a major with possible also more changes on the backend template site etc.

avatar bembelimen bembelimen - change - 22 Oct 2022
The description was changed
avatar bembelimen bembelimen - edited - 22 Oct 2022
avatar bembelimen bembelimen - change - 22 Oct 2022
The description was changed
avatar bembelimen bembelimen - edited - 22 Oct 2022
avatar bembelimen bembelimen - change - 22 Oct 2022
Labels Added: Language Change NPM Resource Changed Maintainers Checked PR-4.3-dev
avatar brianteeman
brianteeman - comment - 22 Oct 2022

Well even when IE11 is EOL its still used in the wild not sure whether it makes much sense to remove it now. J5 a few months from now would be where i would remove such a message as that is a major with possible also more changes on the backend template site etc.

+100

Nothing has changed in our code to justify removing the error message. Joomla admin still will not work with internet explorer but with this PR no one will know that the browser is the cause of the problems and will now think Joomla is broken.

Internet Explorer is still in use even if it is eol and a user should be told when they get an error.

Just because in the wealthy western web the usage of IE has dropped below 1% does not mean that it is true globally.

For example in Iran, where joomla is heavily used due to our almost unique, support for the jihali calendar ie usage is still over 8% https://gs.statcounter.com/browser-market-share/desktop/iran

There are many other countries where Joomla is actively used where the % is 5% or over.

avatar bembelimen bembelimen - change - 22 Oct 2022
Title
[4.3] Remove IE 11 warning message due to EOL
[5.0] Remove IE 11 warning message due to EOL
avatar bembelimen bembelimen - edited - 22 Oct 2022
avatar bembelimen bembelimen - change - 22 Oct 2022
Labels Added: PR-5.0-dev
Removed: PR-4.3-dev
avatar bembelimen bembelimen - change - 22 Oct 2022
The description was changed
avatar bembelimen bembelimen - edited - 22 Oct 2022
avatar brianteeman
brianteeman - comment - 22 Oct 2022

As this has now been rebased to 5.0 please re-open and merge #37900

avatar HLeithner HLeithner - change - 22 Oct 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-10-22 16:09:12
Closed_By HLeithner
avatar HLeithner HLeithner - close - 22 Oct 2022
avatar HLeithner HLeithner - merge - 22 Oct 2022
avatar HLeithner
HLeithner - comment - 22 Oct 2022

Thanks

avatar brianteeman
brianteeman - comment - 22 Oct 2022

Thank you

Add a Comment

Login with GitHub to post a comment