? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
14 Oct 2022

Pull Request for Issue #38958

Open: removing modal from com_sheduler.

Summary of Changes

Fix display of data-function in com_modules, remove data-function in com_scheduler
Remove modal view

Testing Instructions

Compare the html code of Select screens of com_modules and com_scheduler
Try to find a situation where a modal view is missing.

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

No data-function when $function is empty in com_modules, No data-function in com_scheduler
grafik

Remove Modal view

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • [x ] No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • [ x] No documentation changes for manual.joomla.org needed

avatar chmst chmst - open - 14 Oct 2022
avatar chmst chmst - change - 14 Oct 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2022
Category Administration com_modules
avatar chmst chmst - change - 14 Oct 2022
Labels Added: ?
avatar chmst
chmst - comment - 14 Oct 2022

Hopefully thats correct now; removed wrong indents

avatar chmst chmst - change - 15 Oct 2022
The description was changed
avatar chmst chmst - edited - 15 Oct 2022
avatar Quy
Quy - comment - 19 Jan 2023

Before PR:
38959-heading

After PR (missing heading & button):
38959-new-button

avatar chmst
chmst - comment - 20 Jan 2023

Fix toolbar, thank you @Quy

avatar Quy Quy - test_item - 20 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 20 Jan 2023

I have tested this item successfully on ca16170


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38959.

avatar Quy Quy - alter_testresult - 31 Jan 2023 - Quy: Tested successfully
avatar Quy Quy - alter_testresult - 6 Feb 2023 - Quy: Tested successfully
avatar viocassel viocassel - test_item - 15 Feb 2023 - Tested successfully
avatar viocassel
viocassel - comment - 15 Feb 2023

I have tested this item successfully on e957027


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38959.

avatar richard67 richard67 - change - 15 Feb 2023
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 15 Feb 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38959.

avatar fancyFranci fancyFranci - close - 22 Feb 2023
avatar fancyFranci fancyFranci - merge - 22 Feb 2023
avatar fancyFranci fancyFranci - change - 22 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-22 21:47:14
Closed_By fancyFranci
Labels Added: ?
avatar fancyFranci
fancyFranci - comment - 22 Feb 2023

Thank you for cleaning this up!

Add a Comment

Login with GitHub to post a comment