No Code Attached Yet
avatar Flowman
Flowman
14 Oct 2022

Steps to reproduce the issue

Just noticed that someone missed "<?php somthing" in the data-function= part.

<a href="<?php echo Route::_($link); ?>" class="new-module mb-3 comModulesSelectCard" data-function="' . $this->escape($function) : ''; ?>" aria-label="<?php echo Text::sprintf('COM_MODULES_SELECT_MODULE', $name); ?>">

And as com_scheduler select is a copy of com_modules it has the same issue in the the select template. But its not used in the same way, as someone have removed the top $function code. Guess data-function= can be removed from here.

data-function="' . $this->escape($function) : ''; ?>"

The modal view in com_scheduler select is useless to, as it is never used in core and just copied from com_modules.

Expected result

Output correct HTML code.

Actual result

Not the correct HTML code.

System information (as much as possible)

Additional comments

Just some clean-up of core :)

avatar Flowman Flowman - open - 14 Oct 2022
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 14 Oct 2022
avatar chmst chmst - change - 14 Oct 2022
Labels Added: bug
avatar chmst chmst - labeled - 14 Oct 2022
avatar Flowman Flowman - change - 14 Oct 2022
The description was changed
avatar Flowman Flowman - edited - 14 Oct 2022
avatar chmst
chmst - comment - 14 Oct 2022

Partial solution here #38959

Still open: the file modal.php. Removing a file needs more actions. Please @richard67 could you take this part?

avatar richard67
richard67 - comment - 14 Oct 2022

Partial solution here #38959

Still open: the file modal.php. Removing a file needs more actions. Please @richard67 could you take this part?

@chmst What's the problem? The file can be removed from the source code with a PR, and for the deletion on update (i.e. the list of deleted files in script.php) I care later, like it has been all the time in recent years.

avatar chmst chmst - change - 14 Oct 2022
Labels Removed: bug
avatar chmst chmst - unlabeled - 14 Oct 2022
avatar chmst chmst - change - 15 Oct 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-10-15 07:43:21
Closed_By chmst
avatar chmst chmst - close - 15 Oct 2022
avatar chmst
chmst - comment - 15 Oct 2022

Completed the PR #38959, please test.

Add a Comment

Login with GitHub to post a comment