[#38930] - [5.3] Redesign carousel implementation to reflect documentation - bug fix
- Closed
- 19 Nov 2024
- Medium
- Build: 4.2-dev
- # 38930
- Diff
- iteidrm:4.2-dev
User tests: Successful: Unsuccessful:
Summary of Changes
This pull request fixes a bug in the Bootstrap Caraousel implementation of Joomla! (PHP and ES/JS) that causes valid parameters to be removed from the JavaScript options object that is fed to the Carousel instance.
Testing Instructions
I do not know if the Patch Tester extension will do the JavaScript re-build / pre-processing for you, and hope you know best what to do in this regard.
- Activate the debug mode in the global configuration to better be able to inspect the generated JavaScript option object in the source code (Browser: Ctrl + U).
- Install, activate and publish the demo module provided with the pull request on a module position of your choice (e.g. Cassiopeia: main-top). Make sure to set the Menu / Module Assignent to "On all pages".
- Open / refresh the page and change some params in the module manager (e.g. keyboard | wrap to false).
Actual result BEFORE applying this Pull Request
All options set to false are filtered out, causing the carousel to fall back to its default values.
Expected result AFTER applying this Pull Request
Params that can have a false value are recognised and work as expected.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org: https://docs.joomla.org/J4.x:Using_Bootstrap_Components_in_Joomla_4#Carousel (slide vs ride)
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
Demo Module
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change Libraries |
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item ✅ successfully on 780d3d8
Quite tricky to test - I had to edit in some of my own image links into the carousel because those supplied are broken. I can turn on each behaviour in turn and see that they work. I actually learned what some of the terms mean!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38930.
To compile the js:
npm run build:js
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38930.
Ah - I tested this against 5.0.0-beta2-dev
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38930.
@Fedik @dgrammatiko I relabeled this a feature and moved it to 5.1 is this something we want and need?
Looks fine, if it works :)
Ditto
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
| Labels |
Added:
Feature
PBF
PR-5.1-dev
PR-5.2-dev
Removed: ? |
||
This pull request has been automatically rebased to 5.3-dev.
| Title |
|
||||||
| Labels |
Added:
PR-5.3-dev
Removed: PR-5.1-dev PR-5.2-dev |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-11-19 09:19:59 |
| Closed_By | ⇒ | iteidrm |
This pull request has been automatically rebased to 4.3-dev.