? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
5 Oct 2022

Pull Request for Issue #38903 .

Summary of Changes

Changed highliter config to match word "exactly".

Testing Instructions

Apply patch, run npm install
Please follow #38903

Actual result BEFORE applying this Pull Request

Some words highligted partialy, and looks broken.

Expected result AFTER applying this Pull Request

Only whole word is highlighted.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar Fedik Fedik - open - 5 Oct 2022
avatar Fedik Fedik - change - 5 Oct 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2022
Category JavaScript Repository NPM Change
avatar Fedik Fedik - change - 5 Oct 2022
Labels Added: NPM Resource Changed ?
avatar sandewt
sandewt - comment - 5 Oct 2022

I have tested this item ? unsuccessfully on 3818320

BEFORE PATCH:
screen shot 2022-10-05 at 14 00 01
AFTER PATCH: URL IS NOT HIGHLIGHTED
screen shot 2022-10-05 at 14 00 01


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38908.
avatar sandewt sandewt - test_item - 5 Oct 2022 - Tested unsuccessfully
avatar Fedik
Fedik - comment - 5 Oct 2022

For URL need "partial" word hghlight, however "partial" word highlight will break text with "fobafobar" word in URL also.

avatar viocassel viocassel - test_item - 26 Jan 2023 - Tested successfully
avatar viocassel
viocassel - comment - 26 Jan 2023

I have tested this item successfully on 3818320


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38908.

avatar Quy Quy - test_item - 26 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 26 Jan 2023

I have tested this item successfully on 3818320


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38908.

avatar Quy Quy - change - 26 Jan 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 26 Jan 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38908.

avatar fancyFranci fancyFranci - close - 3 Feb 2023
avatar fancyFranci fancyFranci - merge - 3 Feb 2023
avatar fancyFranci fancyFranci - change - 3 Feb 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-02-03 21:21:21
Closed_By fancyFranci
Labels Added: ?
avatar fancyFranci
fancyFranci - comment - 3 Feb 2023

Good that you fixed that. Thank you!

Add a Comment

Login with GitHub to post a comment