[#38900] - TinyMCE fix text dragging
- Fixed in Code Base
- 15 Oct 2022
- Medium
- Build: 4.2-dev
- # 38900
- Diff
- Fedik:tiny-drag-fix
User tests: Successful: Unsuccessful:
Pull Request for Issue #37054 .
Summary of Changes
Update our jdragndrop plugin to work only with "Files".
Testing Instructions
Run npm install, and follow #37054
Would be nice to test in all Browsers.
Actual result BEFORE applying this Pull Request
Text drag is broken
Image upload works
Expected result AFTER applying this Pull Request
Text drag works
Image upload works
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | JavaScript Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38900.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38900.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38900.
| Labels |
Added:
?
Release Blocker
|
||
@Fedik After checking out this branch, running npm ci and testing the editor, the drag and drop of text works but drag and drop of images no longer works. I do not get the dotted line around the block nor does anything happen when I drop the image on the editor.
This is running Firefox 105.0.2 on Linux.
Thanks for checking that. I have fixed Firefox. Please test again
I have tested this item
Works in firefox but not in chrome
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38900.
| Status | Ready to Commit | ⇒ | Pending |
I set it back to Pending
I have tested this item
Before applying the patch I cannot select and move the text. After applying the patch I am able to upload a image via drag n drop and also text can be selected and moved.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38900.
I have tested this item
@Fedik Must have been. works fine today.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38900.
| Status | Pending | ⇒ | Ready to Commit |
RTC
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-15 08:14:21 |
| Closed_By | ⇒ | HLeithner |
Thanks
Added release blocker label as inherited from the issue.