User tests: Successful: Unsuccessful:
Pull Request for Issue #38759 .
Added null coalescing check to prevent null warning.
In the backend:
There were two depreaction warnings like:
Deprecated
: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in
\administrator\templates\atum\index.php
on line
56
Deprecated
: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated in
\administrator\templates\atum\index.php
on line
59
Additional test case 2:
Additional test case 3:
There is no PHP 8.1 warning.
No
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Templates (admin) |
Labels |
Added:
?
|
Labels |
Added:
?
|
I have tested this item
Labels |
Removed:
?
|
I was just typing please update the two error files but you did just di that. Thanks
Unfortunately I have found other places in the code which results in such PHP deprecation warnings. I added two new test cases in the PR description section above.
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-09-15 11:09:23 |
Closed_By | ⇒ | laoneo | |
Labels |
Added:
?
|
Thanks!!
I suggest a default value for the parameter
: 'alt="' . htmlspecialchars($this->params->get('logoBrandLargeAlt', ''), ENT_COMPAT, 'UTF-8') . '"';