[#38761] - Removing unnecessary "Table of" from table caption strings.
- Fixed in Code Base
- 20 Oct 2022
- Medium
- Build: 4.2-dev
- # 38761
- Diff
- crystalenka:table-captions
User tests: Successful: Unsuccessful:
Pull Request for Issue #35279 .
Summary of Changes
Screen readers announce the element type by default; if an individual has set their device to not announce element types, that is their choice. Similar to having "image of" in alt text or "link to" in a link.
See https://russmaxdesign.github.io/accessible-forms/accessible-name-table04.html for how different screen readers handle table captions by default.
Testing Instructions
With your favorite screenreader, navigate to any core component table view and listens how it announces the table.
Actual result BEFORE applying this Pull Request
VoiceOver
Chrome: Table of [component]. Table. 2 Columns. 3 rows.
Firefox: Table of [component]. Table. 2 Columns. 3 rows.
Safari: Table of [component]. Table. 2 Columns. 3 rows.
NVDA
Chrome: Table with 3 rows and 2 columns. Table of [component].
Firefox: Table with 3 rows and 2 columns. Table of [component].
Safari: Table with 3 rows and 2 columns. Table of [component].
JAWS
Chrome: Table with 2 columns and 3 rows. [Name not announced]
Firefox: Table with 2 columns and 3 rows. [Name not announced]
Safari: Table with 2 columns and 3 rows. [Name not announced]
Expected result AFTER applying this Pull Request
VoiceOver
Chrome: [component]. Table. 2 Columns. 3 rows.
Firefox: [component]. Table. 2 Columns. 3 rows.
Safari: [component]. Table. 2 Columns. 3 rows.
NVDA
Chrome: Table with 3 rows and 2 columns. [component].
Firefox: Table with 3 rows and 2 columns. [component].
Safari: Table with 3 rows and 2 columns. [component].
JAWS
Chrome: Table with 2 columns and 3 rows. [Name not announced]
Firefox: Table with 2 columns and 3 rows. [Name not announced]
Safari: Table with 2 columns and 3 rows. [Name not announced]
Documentation Changes Required
None that I'm aware of. Perhaps in developer documentation regarding accurate table captions
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
| Labels |
Added:
Language Change
a11y
?
|
||
Thanks @Kostelano , added those and a couple others I missed originally. Nice catch!
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.
I have tested this item
Because of the latest commit.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.
Sorry this is not correct
api/joomla.ini is supposed to be in sync with the main joomla.ini
| Status | Ready to Commit | ⇒ | Pending |
Back to pending. @crystalenka Could you check @brianteeman 's comment above and adjust the api/joomla.ini file, too? Thanks in advance.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.
There are other differences between api/joomla.ini and the main joomla.ini. Is there a standard that determines which items carry over and which ones do not?
There are other differences between api/joomla.ini and the main joomla.ini. Is there a standard that determines which items carry over and which ones do not?
@crystalenka Which "main joomla.ini" did you check? As far as I know - but I might be wrong - the api file should be equal to the admin file.
@richard67 that is correct
@brianteeman @richard67 I think there was only one in the main joomla.ini. If I missed any other ones please let me know, but I think it's ready now.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.
I have tested this item
Code Review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38761.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-20 14:56:49 |
| Closed_By | ⇒ | roland-d |
Thank you.
Missed. Please make corrections.
administrator\language\en-GB\com_contenthistory.ini
COM_CONTENTHISTORY_COMPARE_CAPTION="Table comparing two versions."administrator\language\en-GB\com_scheduler.ini
COM_SCHEDULER_TABLE_CAPTION="Tasks List"language\en-GB\com_contact.ini
COM_CONTACT_TABLE_CAPTION="Table of Contacts"language\en-GB\com_content.ini
COM_CONTENT_ARTICLES_TABLE_CAPTION="Table of Articles"COM_CONTENT_CATEGORY_LIST_TABLE_CAPTION="List of articles in category %s"language\en-GB\joomla.ini
JGLOBAL_REPEATABLE_FIELDS_TABLE_CAPTION="Table of repeatable fields."