Dashboard and plugin description works, but In modal without then.

Dashboard and plugin description works, but In modal without then.

Yes thats what I wrote :-)

Okay, I thought you will change both :)

I don't know which file to use to change it, no idea why it's not the same as the plugin description :-(

Maybe you can make the "then" in smaller font on the Dashboard?

You changed "Save" to "Apply". It is true that the a button stands for apply, but we have in all toolbars the button SAVE, not Apply.

no idea why it's not the same as the plugin description

it is dinamicaly generated here

Maybe you can make the "then" in smaller font on the Dashboard?

You changed "Save" to "Apply". It is true that the a button stands for apply, but we have in all toolbars the button SAVE, not Apply.

Thank you I changed it. Better now?

Yeah, well, not trivial, require new string for Joomla.Text._('then') :)

no idea why it's not the same as the plugin description

it is dinamicaly generated here

joomla-cms/build/media_source/plg_system_shortcut/js/shortcut.es6.js

Lines 103 to 114 in febdab6

	let dl = '<dl>';
	dlItems.forEach((titles, shortcut) => {
	dl += '<dt><kbd>J</kbd>';
	shortcut.split('+').forEach((key) => {
	dl += ` <kbd>${key.trim()}</kbd>`;
	});
	dl += '</dt>';
	titles.forEach((title) => {
	dl += `<dd>${title}</dd>`;
	});
	});
	dl += '</dl>';

I Found that file but where has this file the "title" from? Because I want to change them too.

Yeah, well, not trivial, require new string for Joomla.Text._('then') :)

why doesn't it take the existing language override?

It comes from plugin

why doesn't it take the existing language override?

The modal shows User defined combination, and so the modal content is dinamicaly generated.

The modal shows User defined combination,

I mean combination that may come from other extennsion with addShortcuts event,

This will do the thing

 dl += ` ${Joomla.Text._('JTHEN')} <kbd>${key.trim()}</kbd>`;

Or full:

let dl = '<dl>';
    dlItems.forEach((titles, shortcut) => {
      dl += '<dt><kbd>J</kbd>';
      shortcut.split('+').forEach(key => {
        dl += ` ${Joomla.Text._('JTHEN')} <kbd>${key.trim()}</kbd>`;
      });
      dl += '</dt>';
      titles.forEach(title => {
        dl += `<dd>${title}</dd>`;
      });
    });
dl += '</dl>';

Maybe constant JTHEN is not very good, then can be something PLG_SYSTEM_SHORTCUT_THEN :)
Not sure here.

But probably, it is fine as you already made, it is less confusing on dashboard now.

Yes but this would not change the titles as in my xml change

1. please dont use <b> it should not be used for styling text https://developer.mozilla.org/en-US/docs/Web/HTML/Element/b
2. I see what you are doing with highlighting one letter but it only really works in english
3. and you had to invent extras for options which really doesnt make sense.

What does X stand for ? @brianteeman

it doesnt stand for anything

it doesnt stand for anything

Let's write the meaning of the shortcuts into brackets so people will remember easier and understand ...

as stated before - it only makes sense in english

also look at any keyboard shortcut system. there doesnt have to be and often isnt any connection between the key and the action

@Fedik should I mention XSS, or the project will also tolerate this one?

@Fedik should I mention XSS, or the project will also tolerate this one?

Do you see a security issue in a language change ? ?

@coolcat-creations not on your side, the existing js code has them. It just need adding the sanitizer in the insertAdjusentHTML call. Again, it’s not about the changes in this pr but the code that was released with 4.2.0

Edit I have further complains about that js but this pr is not the place to express them…

@dgrammatiko maybe it should be reported rather to the JSST ? :-)

@coolcat-creations I think @brianteeman is right, better remove <b> on first letter,
There not always will be a case when first letter will refer to "shortcut", especialy for non Eglish translations.

should I mention XSS

XSS, what is it, kind of new CSS? ?

Ok, I applied the requested changes and added also a language string. I cant test the build (es6 file change) myself because I can't get composer and npm running.

Almost ?

Add new js string around here:

Text::script('PLG_SYSTEM_SHORTCUT_THEN');

@Fedik thanks for your help I will add it :-)

About XSS, I will do separated PR, later, after this one will be merged.

Added :-)

Maybe also make it with <small>, here how it looks
Normal

With <small>:

Just thought, I am fine with any :)

Added :-)

Works now :)

was it intentional to split each to a new line?

No, not at all - but how to prevent it? I only changed the + to "then" ?

was it intentional to split each to a new line?

the description uses ul lists
the popup uses dl lists

@chmst can correct me but I think they both should be dl (definition lists)

To put dt and dd on the same line its just css

As this PR is about language change and not semantic, maybe we could merge it first and then move to semantics and the xss and css stuff? One step at the time would increase the speed of improvements :) that would be great!

Is there a future for this PR to be merged if tested or it it obligated to change semantics and css? If semantics and css need to be changed maybe someone else can take over and I close this one.

I have tested this item ✅ successfully on 0e3bb1f

The aim of this PR was to improve the text, and it is done, so I count it as great success ;)
The styling can be fixed separately, by people who better in it.

I have tested this item ✅ successfully on 0e3bb1f

RTC

thanks