? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
1 Sep 2022

Pull Request for Issue # .

Summary of Changes

  • remove some I/O operations on both the JS and SCSS minification (eg use the code output directly)
  • Switch for Sass to Sass-embedded

About SASS-EMBEDDED: This package is an alternative to the sass package. It supports the same JS API as sass and is maintained by the same team, but where the sass package is pure JavaScript, sass-embedded is instead a JavaScript wrapper around a native Dart executable. This means sass-embedded will generally be much faster especially for large Sass compilations, but it can only be installed on the platforms that Dart supports: Windows, Mac OS, and Linux. npmjs

Testing Instructions

On a fresh installation of Joomla (ie git clone) do the composer install and then the npm install. Copy the media folder somewhere in your hardisk. (check the time needed)
Now clone this PR and do both the composer and npm installations. Once done do a folder compare of the current media folder against the folder that you saved in the previous step. You should have the same files. Check the template.css for both the core templates to ensure that the file contents are the same.

Compare the times and do a brief check that both front end and back still work as expected

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

It should a bit faster due to less I/O operations and the sass-embedded is the recommended compiler for speed

Documentation Changes Required

NO

This PR replaces #38225 and #36919

Note to anyone that will merge this: you probably need at least a successful test both from windows and macOS env (assuming that the linux env from the automated tests can be accepted as one for the Linuxes)

@HLeithner have this merged before trying out more exotic solutions

avatar dgrammatiko dgrammatiko - open - 1 Sep 2022
avatar dgrammatiko dgrammatiko - change - 1 Sep 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Sep 2022
Category Unit Tests JavaScript Repository NPM Change
avatar richard67
richard67 - comment - 1 Sep 2022
avatar dgrammatiko dgrammatiko - change - 1 Sep 2022
Labels Added: ? NPM Resource Changed ?
avatar dgrammatiko
dgrammatiko - comment - 19 Oct 2022

@HLeithner @Hackwar is there any interest for this one or should I close it?

avatar Hackwar
Hackwar - comment - 19 Oct 2022

Yes, there is interest. However I think we wont apply this to 4.2, so I would ask you to rebase this to 4.3-dev and update this branch to the latest changes from that base branch. I hope that we can merge this over this weekend.

avatar dgrammatiko dgrammatiko - change - 19 Oct 2022
Title
[4.2] NPM build tools cleanup/Perf fixes
[4.3] NPM build tools cleanup/Perf fixes
avatar dgrammatiko dgrammatiko - edited - 19 Oct 2022
avatar Hackwar
Hackwar - comment - 19 Oct 2022

I changed the base branch. Please resolve the conflicts and update the branch to the latest changes.

1db9b6b 19 Oct 2022 avatar dgrammatiko x
052a108 19 Oct 2022 avatar dgrammatiko upd
avatar dgrammatiko dgrammatiko - change - 19 Oct 2022
Labels Added: PR-4.3-dev
avatar dgrammatiko
dgrammatiko - comment - 19 Oct 2022

@Hackwar done, could someone bless drone here?

avatar Hackwar
Hackwar - comment - 20 Oct 2022

I send you a PR to sign the drone.yml file

avatar HLeithner HLeithner - change - 21 Oct 2022
Labels Removed: ?
avatar HLeithner HLeithner - close - 21 Oct 2022
avatar HLeithner HLeithner - merge - 21 Oct 2022
avatar HLeithner HLeithner - change - 21 Oct 2022
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-10-21 08:46:35
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 21 Oct 2022

thanks

avatar Hackwar
Hackwar - comment - 21 Oct 2022

🎉

Add a Comment

Login with GitHub to post a comment