User tests: Successful: Unsuccessful:
Pull Request for Issue # .
About SASS-EMBEDDED: This package is an alternative to the sass package. It supports the same JS API as sass and is maintained by the same team, but where the sass package is pure JavaScript, sass-embedded is instead a JavaScript wrapper around a native Dart executable. This means sass-embedded will generally be much faster especially for large Sass compilations, but it can only be installed on the platforms that Dart supports: Windows, Mac OS, and Linux. npmjs
On a fresh installation of Joomla (ie git clone
) do the composer install and then the npm install. Copy the media folder somewhere in your hardisk. (check the time needed)
Now clone this PR and do both the composer and npm installations. Once done do a folder compare of the current media folder against the folder that you saved in the previous step. You should have the same files. Check the template.css for both the core templates to ensure that the file contents are the same.
Compare the times and do a brief check that both front end and back still work as expected
It should a bit faster due to less I/O operations and the sass-embedded is the recommended compiler for speed
NO
This PR replaces #38225 and #36919
Note to anyone that will merge this: you probably need at least a successful test both from windows and macOS env (assuming that the linux env from the automated tests can be accepted as one for the Linuxes)
@HLeithner have this merged before trying out more exotic solutions
Status | New | ⇒ | Pending |
Category | ⇒ | Unit Tests JavaScript Repository NPM Change |
Labels |
Added:
?
NPM Resource Changed
?
|
@HLeithner @Hackwar is there any interest for this one or should I close it?
Yes, there is interest. However I think we wont apply this to 4.2, so I would ask you to rebase this to 4.3-dev and update this branch to the latest changes from that base branch. I hope that we can merge this over this weekend.
Title |
|
I changed the base branch. Please resolve the conflicts and update the branch to the latest changes.
Labels |
Added:
PR-4.3-dev
|
I send you a PR to sign the drone.yml file
Labels |
Removed:
?
|
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-21 08:46:35 |
Closed_By | ⇒ | HLeithner |
thanks
@dgrammatiko The JS linter complains: https://ci.joomla.org/joomla/joomla-cms/57462/1/26