? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
28 Aug 2022

In the user profile plugin there is a Terms of Service field that is required on registration. It has an optional accompanying field to link to an article.

Pull Request for Issue #28537 .

Summary of Changes

Before this PR the logic for checking that a user had agreed to the terms of service was broken so thta if there is no linked article the cjeck is never performed and a user can still register even if they dont agree.

This PR removes the check for the existence of the article and tweaks the language string used in the error message accordingly

Testing Instructions

  • enable user registration
  • enable the user profile plugin
  • try to create a new user without agreeing to the terms

Actual result BEFORE applying this Pull Request

User created

Expected result AFTER applying this Pull Request

User not created and error message displayed

avatar brianteeman brianteeman - open - 28 Aug 2022
avatar brianteeman brianteeman - change - 28 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 28 Aug 2022
Category Administration Language & Strings Front End Plugins
avatar Kostelano
Kostelano - comment - 28 Aug 2022

I have tested this item successfully on 420ed1e

Thanks, it works.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38619.

avatar Kostelano Kostelano - test_item - 28 Aug 2022 - Tested successfully
avatar viocassel
viocassel - comment - 28 Aug 2022

I have tested this item successfully on 420ed1e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38619.

avatar viocassel viocassel - test_item - 28 Aug 2022 - Tested successfully
avatar richard67 richard67 - change - 28 Aug 2022
Status Pending Ready to Commit
Labels Added: Language Change ?
avatar richard67
richard67 - comment - 28 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38619.

avatar brianteeman brianteeman - change - 28 Aug 2022
Labels Added: ?
avatar richard67
richard67 - comment - 28 Aug 2022

@Quy Does it need new tests? From my point of view RTC is still ok, I've just reviewed that last change.

avatar Quy
Quy - comment - 28 Aug 2022

It is not necessary as it is an obsolete variable.

avatar roland-d roland-d - change - 31 Aug 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-08-31 21:13:59
Closed_By roland-d
avatar roland-d roland-d - close - 31 Aug 2022
avatar roland-d roland-d - merge - 31 Aug 2022
avatar roland-d
roland-d - comment - 31 Aug 2022

Thank you

avatar brianteeman
brianteeman - comment - 31 Aug 2022

thanks

Add a Comment

Login with GitHub to post a comment