Feeling Lucky
?
?
[#38617] - Text area and edit field defaults
- Fixed in Code Base
- 6 Sep 2022
- Medium
- Build: 4.2-dev
- # 38617
- Diff
- brianteeman:field_sql
User tests: Successful: Unsuccessful:
The default values for these two fields was not being set during installation. This PR will fix that for new installs. We can't do updates as it would be changing user data
code review should be fine
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | SQL Installation Postgresql |
richard67
- comment
- 28 Aug 2022
I have tested this item
Tested with MySQL and MariaDB and PostgreSQL (recent versions) that the "params" values saved in database when saving the plugins options without having made changes after a new install are equal to what this PR adds to the SQL.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38617.
viocassel
- comment
- 29 Aug 2022
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38617.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
richard67
- comment
- 29 Aug 2022
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38617.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-09-06 19:55:39 |
| Closed_By | ⇒ | fancyFranci | |
| Labels |
Added:
?
|
||
fancyFranci
- comment
- 6 Sep 2022
Good that you fixed that. Thank you!
brianteeman
- comment
- 6 Sep 2022
thx
@brianteeman Checking elsewhere in the SQL, the integer values are quoted with double quotes, too, e.g. here:
https://github.com/joomla/joomla-cms/pull/38617/files#diff-3a9a51c74db65d66b70dbd56c86e63882cfaa26701ef6ff3f88bd0ea2682bb9fR286
https://github.com/joomla/joomla-cms/pull/38617/files#diff-d6e22b9d36df769fc1e7f3e847faf6374793792fe81b73166837406587ab3348R292
On the other hand, when saving the parameters of that field or of the fields modified by your PR, the integer values are not quoted. I've tested with MySQL and MariaDB and PostgreSQL.
So your PR is right.
But it seems we could clean up the quotes elsewhere, too (of course not with this PR).