[#38612] - Pagination Only child
- Fixed in Code Base
- 6 Sep 2022
- Medium
- Build: 4.2-dev
- # 38612
- Diff
- brianteeman:pagination_only_child
User tests: Successful: Unsuccessful:
Pull request for #38512
When there is only a next button it is no longer on the right as intended. this was due to a change in the markup.
As this a change in the scss you will need to either npm run build:css or use one of the prebuilt packages
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change Front End Plugins |
I am not changing the size, just fixing the bug
I am not changing the size, just fixing the bug
That would be a new PR.
English: successful test
Arabic: successful test ???
Can anyone confirm that this test is also successful.
I have tested this item
works after running npm ci as instructed
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38612.
| Status | Pending | ⇒ | Ready to Commit |
@brianteeman ok, it comes from an extension for chrome called Docs Creator
see I'm not daft
@brianteeman Is the screenshot for RTL in @sandewt 's comment above ok? He was not sure if his test with Arabic can be counted as success. I think it's because of the position of the button, it seems to have some margin left which it doesn's have with LTR.
@N6REJ As there was one test only, i.e. yours, it cannot be RTC. @sandewt test for RTL (Arabic) was not clear.
| Status | Ready to Commit | ⇒ | Pending |
| Labels |
Added:
NPM Resource Changed
?
|
||
Back to pending.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38612.
Yes that's fine as an RTL trst
@sandewt As @brianteeman confirmed that your test for RTL direction with Arabic is ok, I was so free to set your test result to success.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38612.
I was so free to set your test result to success.
@richard67 that's OK. Thks.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38612.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-09-06 10:03:12 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
thanks
I'm not a designer, but the button looks very small, please make it a bit bigger. Add p-2.
E.g. class="btn p-2 btn-sm btn-secondary next"
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38612.