? ? Pending

User tests: Successful: Unsuccessful:

avatar chmst
chmst
26 Aug 2022

Pull Request for Issue # .

Summary of Changes

It is possible to add new modules to a dashboard. The dashboard name should be preselected in the position field, as it is a special position for every component (also for own components).
The PR adds the clientID to the position filter.

It was possible in former 4 versions but forgotten here #33763

Testing Instructions

Open any dashboard for example users.
Click the "add new module" button and select a module, the module is opened.

Actual result BEFORE applying this Pull Request

The position field shows "none"
grafik

You have to search for the right position in the list of possible positions

Expected result AFTER applying this Pull Request

In the position field the name of the active dashboard is preselected

grafik

Documentation Changes Required

avatar chmst chmst - open - 26 Aug 2022
avatar chmst chmst - change - 26 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Aug 2022
Category Administration com_cpanel
avatar chmst chmst - change - 26 Aug 2022
The description was changed
avatar chmst chmst - edited - 26 Aug 2022
avatar chmst chmst - change - 26 Aug 2022
The description was changed
avatar chmst chmst - edited - 26 Aug 2022
avatar chmst chmst - change - 26 Aug 2022
The description was changed
avatar chmst chmst - edited - 26 Aug 2022
avatar bembelimen
bembelimen - comment - 26 Aug 2022

I have tested this item successfully on 2f138ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38611.

avatar bembelimen bembelimen - test_item - 26 Aug 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 Aug 2022

I have tested this item successfully on 2f138ec


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38611.

avatar brianteeman brianteeman - test_item - 26 Aug 2022 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 Aug 2022

Thank you - this also closed #35153

avatar bembelimen bembelimen - change - 26 Aug 2022
Status Pending Ready to Commit
Labels Added: ?
avatar bembelimen
bembelimen - comment - 26 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38611.

avatar wilsonge
wilsonge - comment - 27 Aug 2022

Can we concat this into the existing string for readability? Otherwise we’re going to forget whether 1 is an array key or what in the future

avatar chmst chmst - change - 27 Aug 2022
Labels Added: ?
avatar chmst
chmst - comment - 27 Aug 2022

With variable? @wilsonge

avatar fancyFranci fancyFranci - change - 6 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-06 20:09:13
Closed_By fancyFranci
avatar fancyFranci fancyFranci - close - 6 Sep 2022
avatar fancyFranci fancyFranci - merge - 6 Sep 2022
avatar fancyFranci
fancyFranci - comment - 6 Sep 2022

Thanks for finding and fixing this issue!

Add a Comment

Login with GitHub to post a comment