Feeling Lucky
?
PR-4.3-dev
[#38593] - Add ldap tests
- Fixed in Code Base
- 15 Sep 2022
- Medium
- Build: 4.3-dev
- # 38593
- Diff
- tatankat:add_ldap_tests
User tests: Successful: Unsuccessful:
Pull Request for missing LDAP tests as mentioned by @HLeithner in #37962 .
Summary of Changes
- add ldap service to drone and appveyor
- add certificates
- added tests for authentication against ldap database
Testing Instructions
run the unit tests with #38421 applied (or an equally patched phpunit.xml)
Actual result BEFORE applying this Pull Request
no ldap tests (Tests: 784, Assertions: 1264, Skipped: 4.)
Expected result AFTER applying this Pull Request
5 more tests, 3 more assertions, 2 more skipped test (waiting for PRs #37962 and #37959)
Documentation Changes Required
Maybe: need to run the ldap docker image to run tests
tests/Unit/README.md should be updated on how to run the unit tests locally. I can add this once the general idea of this PR is approved.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Unit Tests |
| Labels |
Added:
?
PR-4.3-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-09-15 14:07:10 |
| Closed_By | ⇒ | Hackwar |
Now it also works on appveyor, thanks to the bitnami team, who accepted my PRs for their openldap image to include more logging so I could find the problem and to fix running as windows Administrator.
It also worked in drone last time it ran there (see https://ci.joomla.org/joomla/joomla-cms/57306).
So, can someone (@HLeithner) (re)take a look at this?