? Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
24 Aug 2022

Pull Request for Issue #36322 .

Summary of Changes

Due to a bug in the way the parent group field was calculated it was not possible to rename the Public usergroup. Now you can.

Testing Instructions

Edit the public usergroep
Change the name
Save

Actual result BEFORE applying this Pull Request

Error: "Invalid field: Group Parent"

Expected result AFTER applying this Pull Request

New name is saved

Documentation Changes Required

Remove "The default groups should not be edited!" from the docs

Notes

  1. This will now allow a site owner to rename all the groups to those for their own language instead of english
  2. If desired a future pull request could be created to allow translations of the group names for a multilingual website. But that would have to wait for 4.3 as it would be a feature not a bug fix like this PR
avatar brianteeman brianteeman - open - 24 Aug 2022
avatar brianteeman brianteeman - change - 24 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 Aug 2022
Category Administration com_users Language & Strings
avatar Kostelano
Kostelano - comment - 24 Aug 2022

I have tested this item successfully on a94a0d1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38592.

avatar Kostelano Kostelano - test_item - 24 Aug 2022 - Tested successfully
avatar viocassel
viocassel - comment - 24 Aug 2022

I have tested this item successfully on a94a0d1


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38592.

avatar viocassel viocassel - test_item - 24 Aug 2022 - Tested successfully
avatar chmst
chmst - comment - 25 Aug 2022

Thanks for this PR.

As users can replace the name "public" now to "wrdlbrmpft", I think it is better to let the English defalt names for all languages also in future. It woul need rewriting lots of tutorials.

avatar brianteeman
brianteeman - comment - 25 Aug 2022

If I ran a multlingual site I would definitely want my non-english speaking admins to be able to understand what the groups are. For people who use a different character set its even harder to understand - thats why I will make it multlingual translatable in a future pr. (just like workflows is)

avatar chmst chmst - change - 25 Aug 2022
The description was changed
Status Pending Ready to Commit
avatar chmst chmst - edited - 25 Aug 2022
avatar chmst
chmst - comment - 25 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38592.

avatar roland-d roland-d - change - 31 Aug 2022
Labels Added: ? Language Change ?
avatar roland-d roland-d - change - 31 Aug 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-08-31 21:50:30
Closed_By roland-d
avatar roland-d roland-d - close - 31 Aug 2022
avatar roland-d roland-d - merge - 31 Aug 2022
avatar roland-d
roland-d - comment - 31 Aug 2022

Thank you

avatar brianteeman
brianteeman - comment - 31 Aug 2022

thanks

Add a Comment

Login with GitHub to post a comment