[#38583] - [5.0] Batch Copy & Move tags
- Closed
- 26 Sep 2023
- Medium
- Build: 4.2-dev
- # 38583
- Diff
- brianteeman:batch_tags
User tests: Successful: Unsuccessful:
Pull Request for Issue #23304 .
Summary of Changes
Solves a four year old feature request ;)
Adds the ability to copy and move tags
chrome_tzUQls3i1J.mp4
Its a new feature so its against the 4.3 branch
Testing Instructions
It requires the tag alias bug fix from #38576
It contains an updated javascript so run npm build:js
See video
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | com_tags Administration Language & Strings JavaScript Repository NPM Change |
| Labels |
Added:
Language Change
NPM Resource Changed
?
|
||
I'm not making the requested changes. It makes no sense to me to have two different code styles for identical code. When phpcs finally detects these things then it can automatically do it.
Ok. I'll delete the comments for short array syntax and null coalescing.
But what about the changes with getCurrentUser?. Here the other components have been adjusted in 4.3-dev.
| Labels |
Added:
PR-4.3-dev
Removed: ? |
||
But what about the changes with getCurrentUser?. Here the other components have been adjusted in 4.3-dev.
Yes that one makes sense and I have accepted the change
Updating branch to retrigger drone
Updating branch to restart the broken drone
update array code style
This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.
| Title |
|
||||||
| Labels |
Added:
Feature
PR-5.0-dev
Removed: PR-4.3-dev |
||
No video so can't test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38583.
No video so can't test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38583.
look on github !!
I tried to download the prebuilt package by clicking Details link but it results in a "Not found" error.
PR is too old, New link will be created shortly
I tried to test it by installing the full package from download > Details link. But in the batch popup the new field is missing. (I'm testing with super user rights). When I debug it, the following layout
<?php echo LayoutHelper::render('joomla.html.batch.tagcopymove', []); ?>
could not be found (does not exist). Shouldn't it be here: /layouts/joomla/html/batch/tagcopymove.php
I have tested this item ? unsuccessfully on d62ae9a
See my comment above.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38583.
feel free to submit a pr to fix anything you see to my branch. I wrote this 13 months ago for joomla 4.3 and I dont really have the time to dig back into the code myself to look at the changes for this
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-26 06:54:51 |
| Closed_By | ⇒ | brianteeman |
I'm not making the requested changes. It makes no sense to me to have two different code styles for identical code. When phpcs finally detects these things then it can automatically do it.