No Code Attached Yet
avatar ReLater
ReLater
18 Aug 2022

Steps to reproduce the issue

grafik

  • Save&Close
  • Click button "Check for updates" when Update Checker doesn't start automatically.
  • Go through update to version 4.2.1-dev.

Issue starts:

  • Click button "Check for updates".
  • Click on button "Reinstall Joomla! core files".

Expected result

  • Current nightly 4.2.1-dev package will be picked and installed. Like on Joomla 3, Joomla 4.1.5.

Actual result

  • Nothing happens. Button link not populated correctly by JavaScript.
  • Activate Debug Mode. Try again.

See browser Javascript console:

Uncaught TypeError: updateCheck is null

grafik

System information (as much as possible)

  • PHP8.1
  • Firefox (current version)

Additional comments

  • Also tested with 4.3.0-dev, 4.2.0-dev, whatever.
avatar ReLater ReLater - open - 18 Aug 2022
avatar joomla-cms-bot joomla-cms-bot - change - 18 Aug 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 18 Aug 2022
avatar ReLater ReLater - change - 18 Aug 2022
The description was changed
avatar ReLater ReLater - edited - 18 Aug 2022
avatar ReLater ReLater - change - 18 Aug 2022
The description was changed
avatar ReLater ReLater - edited - 18 Aug 2022
avatar ReLater ReLater - change - 18 Aug 2022
The description was changed
avatar ReLater ReLater - edited - 18 Aug 2022
avatar ReLater ReLater - change - 18 Aug 2022
The description was changed
avatar ReLater ReLater - edited - 18 Aug 2022
avatar zero-24
zero-24 - comment - 18 Aug 2022

Just to be sure you can 100% reproduce that on a freshly installed 4.1.5 stable? On a quick look the update server looks good as well as the updater can not be broken as many updated from 4.1.5 to 4.2.0 (exect the known issues)

avatar ReLater
ReLater - comment - 18 Aug 2022

I'll test again with a new 4.1.5 install.

I see that button behavior on any 4.2 site (dev or stable). Doesn't matter what the base version was. And see it for a longer time now.

But: Even if the update server url is wrong or XML damaged, whatever, there should not be a JS error.

avatar zero-24
zero-24 - comment - 18 Aug 2022

I agree this is why i "hope" it has something todo with the local site you are doing your testing with else we might have another major issue with the updater component.

avatar ReLater
ReLater - comment - 18 Aug 2022

I agree this is why i "hope" it has something todo with the local site you are doing your testing with else we might have another major issue with the updater component.

I always test online. No local sites.

To clarify

I'm already on 4.2.1-dev. And then I get the updateCheck JS error. Can't reinstall the files.

The link behind the "Reinstall" is .../administrator/index.php?option=com_joomlaupdate# then.

New test with fresh 4.1.5

Same behavior like described in opener post.

4.1.5: All works like expected. Updatechecker. Update. Reinstall. No issues. => 4.2.1-dev installed now.

4.2.1-dev: See opener post. Firefox and Vivaldi. Console on Vivaldi differs a bit but same file, same line:

grafik

Deleted cache folder via FTP between each tests.

avatar zero-24
zero-24 - comment - 18 Aug 2022

I'm sorry I'm not at my desk right now but can you please verify whether and update via the "regular" update path works and just the reinstall is broken?
So 4.2.0 -> 4.2.1-dev via the next_patch update server works or not.

avatar zero-24 zero-24 - change - 18 Aug 2022
Labels Added: Release Blocker
avatar zero-24 zero-24 - labeled - 18 Aug 2022
avatar zero-24 zero-24 - change - 18 Aug 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-08-18 17:22:39
Closed_By zero-24
avatar zero-24 zero-24 - close - 18 Aug 2022
avatar zero-24
zero-24 - comment - 18 Aug 2022

PR here @ReLater please test works good for me: #38519 (comment)

avatar zero-24 zero-24 - change - 18 Aug 2022
Labels Removed: Release Blocker
avatar zero-24 zero-24 - unlabeled - 18 Aug 2022

Add a Comment

Login with GitHub to post a comment