? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
17 Aug 2022

Changes the css classes for the dropdown column selector to remove text wrapping which is especially a problem in German but can also be seen in english in the category list view

Pull Request for Issue #38503 .

Testing Instructions

Either npm run build:js or install a prebuilt package

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

avatar brianteeman brianteeman - open - 17 Aug 2022
avatar brianteeman brianteeman - change - 17 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 17 Aug 2022
Category JavaScript Repository NPM Change
avatar sba
sba - comment - 18 Aug 2022

looks good to me. thanks @brianteeman !

avatar sandewt
sandewt - comment - 18 Aug 2022

I have tested this item successfully on e5421a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507.

avatar sandewt sandewt - test_item - 18 Aug 2022 - Tested successfully
avatar sandewt
sandewt - comment - 18 Aug 2022

Result test:

screen shot 2022-08-18 at 07 49 26


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507.

avatar viocassel
viocassel - comment - 18 Aug 2022

I have tested this item successfully on e5421a9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507.

avatar viocassel viocassel - test_item - 18 Aug 2022 - Tested successfully
avatar alikon alikon - change - 18 Aug 2022
Status Pending Ready to Commit
avatar alikon
alikon - comment - 18 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507.

avatar Quy Quy - change - 18 Aug 2022
Labels Added: ? ?
avatar heelc29
heelc29 - comment - 22 Aug 2022

@brianteeman Could the margin, at the bottom of the ul-element, be removed .mb-0?
image

avatar brianteeman
brianteeman - comment - 22 Aug 2022

Bottom margin removed as requested

avatar brianteeman brianteeman - change - 22 Aug 2022
Labels Added: NPM Resource Changed
avatar heelc29
heelc29 - comment - 22 Aug 2022

I have tested this item successfully on 30a9c9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507.

avatar heelc29 heelc29 - test_item - 22 Aug 2022 - Tested successfully
avatar viocassel
viocassel - comment - 22 Aug 2022

I have tested this item successfully on 30a9c9d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38507.

avatar viocassel viocassel - test_item - 22 Aug 2022 - Tested successfully
avatar wilsonge wilsonge - change - 6 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-06 10:26:55
Closed_By wilsonge
avatar wilsonge wilsonge - close - 6 Sep 2022
avatar wilsonge wilsonge - merge - 6 Sep 2022
avatar brianteeman
brianteeman - comment - 6 Sep 2022

thank you

Add a Comment

Login with GitHub to post a comment