[#38498] - Remove unused imports in MFA
- Fixed in Code Base
- 18 Aug 2022
- Medium
- Build: 4.2-dev
- # 38498
- Diff
- nikosdion:fix/38483-unused-import
User tests: Successful: Unsuccessful:
Pull Request for Issue #38483 .
Summary of Changes
Removes unnecessary imports in com_users classes and view templates touched by the MFA feature.
This is a code quality PR @HLeithner @roland-d
Testing Instructions
Install a site and use the MFA feature.
Actual result BEFORE applying this Pull Request
Everything works.
Expected result AFTER applying this Pull Request
Everything still works.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users |
Thanks! I didn't have both their GitHub handles :)
Thanks @nikosdion I was a bit scared to rely on my ide without fully understanding it to create the pr myself
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38498.
@brianteeman You're welcome! This was easy for me, I could even tell why these use statements were left behind. I had started this as a standalone component, moved it to a com_users feature then went into two major refactoring rounds. The leftovers were indeed from the three refactoring rounds.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38498.
| Labels |
Added:
?
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-08-18 19:23:22 |
| Closed_By | ⇒ | roland-d |
Thank you
Thanks but I think @fancyFranci should be mentioned here as release lead. Would expect that get merged after we have a stable 4.2 release.