[#38497] - [4.x] Naming of overridden file (editable) is not chosen correctly.
- Closed
- 21 Aug 2022
- Medium
- Build: [4.x]
- # 38497
Steps to reproduce the issue
Goto:
- Templates: Customise (Cassiopeia) > Editor > /templates/cassiopeia > html
Expected result
Naming:
Override file (editable)
Actual result
Naming:
Overridden file (editable)
System information (as much as possible)
J4
Additional comments
Because this file is NOT overriden, that is the Original file.
| Labels |
Removed:
?
|
||
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
Linguistically this is a bit weird and I think it is currently wrong but would like to hear more views.
Overridden is the past participle
The original file is being overridden by the new file and The overridden file is the new file are both correct uses of the word overridden. Which means calling this new file the overridden file is indeed wrong.
therefore we have an **original ** and an **override **
I would agree, neither usage is horribly wrong, just confusing. A past participle describes a completed action so the use of overridden should refer to the original file being amended not to its new state.
For clarity is it not better to have an Original file and an Override file, which is the present and future simple tense?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38497.
For clarity is it not better to have an Original file and an Override file, which is the present and future simple tense?
Thats my current thinking as well. Lets leave this open for some other comments and then we can create a pr
@brianteeman Does your PR #38541 close this issue?
Yes this can be closed
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-08-21 14:56:47 |
| Closed_By | ⇒ | richard67 |
The override file is the one which overrides the original file, so the original file is the one being overridden. I do not see any mistake in that terminology.