? ? Pending

User tests: Successful: 0 Unsuccessful: 0

avatar tatankat
tatankat
8 Aug 2022

Summary of Changes

Remove Libraries subdirectory from directory configuration in phpunit config, so Component and Plugin tests are also executed.

Testing Instructions

run phpunit and see more tests being done

Actual result BEFORE applying this Pull Request

765 tests executed

Expected result AFTER applying this Pull Request

786 tests executed

Documentation Changes Required

None that I know of.

avatar tatankat tatankat - open - 8 Aug 2022
avatar tatankat tatankat - change - 8 Aug 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Aug 2022
Category Unit Tests
avatar laoneo laoneo - change - 8 Aug 2022
Labels Added: ? ?
avatar rdeutz
rdeutz - comment - 8 Aug 2022
  1. If you want to add more tests than you can add more testsuites.
  2. Our CI fails on you change, what is not a good sign.
avatar tatankat
tatankat - comment - 8 Aug 2022
  1. If you want to add more tests than you can add more testsuites.

I do not want to add more tests. The tests are already written and part of the repository, they are just not executed.

  1. Our CI fails on you change, what is not a good sign.

The CI fails on the tests that were already there. Problem is they do not fail when I run them locally. I have no idea why they fail on the CI.

avatar laoneo
laoneo - comment - 9 Aug 2022

The problem is that in drone the tests are executed as root, so it can create the invalid folders. I made an alternative pr where I fixed the tests in #38421. Can you have a look on this pr @tatankat?

avatar tatankat tatankat - change - 9 Aug 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-08-09 08:36:10
Closed_By tatankat
avatar tatankat
tatankat - comment - 9 Aug 2022

@laoneo Nice, thanks for looking into it and the work done! I will close this one in favor of #38421

avatar tatankat tatankat - close - 9 Aug 2022

Add a Comment

Login with GitHub to post a comment