? Release Blocker NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
31 Jul 2022

This is a new feature in 4.2 and the RTL css is wrong - please make this a release blocker @roland-d @richard67

Summary of Changes

For some reason Bootstrap uses text-align: left instead of logical properties for this which completely breaks the layout in RTL so we sadly need to add an rtl override.

Testing Instructions

This is a css change so either npm run build:css or install a pre-built package

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Documentation Changes Required

avatar brianteeman brianteeman - open - 31 Jul 2022
avatar brianteeman brianteeman - change - 31 Jul 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2022
Category Repository NPM Change
avatar tecpromotion
tecpromotion - comment - 1 Aug 2022

Works for me

screen shot 2022-08-01 at 07 39 02


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38360.

avatar tecpromotion
tecpromotion - comment - 1 Aug 2022

I have tested this item successfully on c85a03e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38360.

avatar tecpromotion tecpromotion - test_item - 1 Aug 2022 - Tested successfully
avatar rdeutz rdeutz - change - 1 Aug 2022
Labels Added: Release Blocker NPM Resource Changed ?
avatar Quy
Quy - comment - 1 Aug 2022

I have tested this item successfully on 0f33664


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38360.

avatar Quy Quy - change - 1 Aug 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 1 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38360.

avatar Quy Quy - test_item - 1 Aug 2022 - Tested successfully
avatar Quy Quy - alter_testresult - 1 Aug 2022 - tecpromotion: Tested successfully
avatar roland-d roland-d - change - 1 Aug 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-08-01 12:14:52
Closed_By roland-d
Labels Added: ?
avatar roland-d roland-d - close - 1 Aug 2022
avatar roland-d roland-d - merge - 1 Aug 2022
avatar roland-d
roland-d - comment - 1 Aug 2022

Thank you

Add a Comment

Login with GitHub to post a comment