Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#38359] - metis-menu css logical proprties

? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
31 Jul 2022

There is no need to add this conditional css for rtl when we can just use logical css properties instead.

The original PR that added this was joomla/cassiopeia#243

code review should be fine

avatar brianteeman brianteeman - open - 31 Jul 2022
avatar brianteeman brianteeman - change - 31 Jul 2022
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2022
Category ⇒ Repository NPM Change
avatar brianteeman brianteeman - change - 21 Oct 2022
Labels Added: NPM Resource Changed ?
avatar webgras
webgras - comment - 21 Nov 2022

I just did a code review - looks fine.

avatar Quy Quy - test_item - 2 Jan 2023 - Tested successfully
avatar Quy
Quy - comment - 2 Jan 2023

I have tested this item ✅ successfully on 25c596b

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38359.

avatar Quy Quy - alter_testresult - 2 Jan 2023 - webgras: Tested successfully
avatar Quy Quy - change - 2 Jan 2023
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 2 Jan 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38359.

avatar fancyFranci fancyFranci - change - 7 Jan 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-01-07 17:19:20
Closed_By ⇒ fancyFranci
Labels Added: ?
avatar fancyFranci fancyFranci - close - 7 Jan 2023
avatar fancyFranci fancyFranci - merge - 7 Jan 2023
avatar fancyFranci
fancyFranci - comment - 7 Jan 2023

Much better! Thank you

avatar brianteeman
brianteeman - comment - 7 Jan 2023

Thanks

Add a Comment

Login with GitHub to post a comment