? NPM Resource Changed PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
31 Jul 2022

I can't find any use of the classes in this additional css file - so lets kill it.

code review

avatar brianteeman brianteeman - open - 31 Jul 2022
avatar brianteeman brianteeman - change - 31 Jul 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2022
Category Administration com_admin com_menus Repository NPM Change
avatar Fedik
Fedik - comment - 31 Jul 2022

This also need to remove then:

{
"name": "com_menus.admin-item-edit-modules",
"type": "style",
"uri": "com_menus/admin-item-edit_modules.min.css"
},

avatar brianteeman brianteeman - change - 31 Jul 2022
Labels Added: NPM Resource Changed ?
avatar Fedik
Fedik - comment - 31 Jul 2022

I have tested this item successfully on 507279a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38353.

avatar Fedik Fedik - test_item - 31 Jul 2022 - Tested successfully
avatar RickR2H
RickR2H - comment - 2 Aug 2022

I have tested this item successfully on 507279a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38353.

avatar RickR2H RickR2H - change - 2 Aug 2022
Status Pending Ready to Commit
avatar RickR2H
RickR2H - comment - 2 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38353.

avatar RickR2H RickR2H - test_item - 2 Aug 2022 - Tested successfully
avatar fancyFranci
fancyFranci - comment - 15 Sep 2022

I really love to remove unused stuff but I'm moving this to 4.3. I want to be sure it doesn't break someones page on 4.2.

avatar brianteeman
brianteeman - comment - 15 Sep 2022

Very sad face. Just passing the buck

avatar obuisard obuisard - change - 17 Sep 2022
Labels Added: ? PR-4.3-dev
Removed: ?
avatar obuisard obuisard - change - 17 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-17 17:09:16
Closed_By obuisard
avatar obuisard obuisard - close - 17 Sep 2022
avatar obuisard obuisard - merge - 17 Sep 2022
avatar obuisard
obuisard - comment - 17 Sep 2022

Thank you Brian @brianteeman!

Add a Comment

Login with GitHub to post a comment