? NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
31 Jul 2022

Summary of Changes

Change css to logical proprty to make sure it works as intended in RTL and LTR

Testing Instructions

This is a css change so either run npm build:css or use a [re-built package
LTR
image

RTL
image

Actual result BEFORE applying this Pull Request

LTR
image

RTL
image

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar brianteeman brianteeman - open - 31 Jul 2022
avatar brianteeman brianteeman - change - 31 Jul 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 31 Jul 2022
Category Repository NPM Change
avatar tecpromotion
tecpromotion - comment - 1 Aug 2022

works for me.
screen shot 2022-08-01 at 07 52 44


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38352.

avatar tecpromotion
tecpromotion - comment - 1 Aug 2022

I have tested this item successfully on 12cf1e3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38352.

avatar tecpromotion tecpromotion - test_item - 1 Aug 2022 - Tested successfully
avatar Quy
Quy - comment - 1 Aug 2022

I have tested this item successfully on 12cf1e3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38352.

avatar Quy Quy - change - 1 Aug 2022
The description was changed
Status Pending Ready to Commit
Labels Added: ?
avatar Quy Quy - edited - 1 Aug 2022
avatar Quy
Quy - comment - 1 Aug 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38352.

avatar Quy Quy - test_item - 1 Aug 2022 - Tested successfully
avatar wilsonge wilsonge - change - 5 Sep 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-09-05 12:05:10
Closed_By wilsonge
Labels Added: ? NPM Resource Changed
avatar wilsonge
wilsonge - comment - 5 Sep 2022

Thanks!

avatar brianteeman
brianteeman - comment - 5 Sep 2022

thanks

Add a Comment

Login with GitHub to post a comment