PR-4.3-dev Pending

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
26 Jul 2022

What the title says.

avatar Hackwar Hackwar - open - 26 Jul 2022
avatar Hackwar Hackwar - change - 26 Jul 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Jul 2022
Category Libraries
avatar brianteeman
brianteeman - comment - 26 Jul 2022

Don't you need to change this as well ?

public const CODENAME = 'Uaminifu';

avatar Hackwar
Hackwar - comment - 26 Jul 2022

Yes, seems like my manual editing isn't the way to go. I've opened this PR mainly to be a reminder and to fix another issue. Most likely we'll simply close this PR.

avatar zero-24
zero-24 - comment - 26 Jul 2022

Don't you need to change this as well ?

technically no I set mine just with the first RC but when there is a codename already defined go for it. Usually the version numbers should be updated using the build/bump.php script that will help here to update everything correctly and we dont miss anything.

avatar wojsmol
wojsmol - comment - 26 Jul 2022

For the version bump we have https://github.com/joomla/joomla-cms/blob/4.3-dev/build/bump.php witch supports also changing of codename.

//edit as mention by Tobias

avatar Hackwar Hackwar - change - 26 Jul 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-07-26 16:03:47
Closed_By Hackwar
Labels Added: PR-4.3-dev
avatar Hackwar Hackwar - close - 26 Jul 2022
avatar zero-24
zero-24 - comment - 26 Jul 2022

Done here on behalf of the Release Leads: 0afad92

Add a Comment

Login with GitHub to post a comment