[#38328] - [4.3] Use the Web Asset Manager
- Fixed in Code Base
- 28 Jan 2023
- Medium
- Build: 4.3-dev
- # 38328
- Diff
- brianteeman:wam
User tests: Successful: Unsuccessful:
As all the htmlhelper behviors are deprecated this PR continues the work to remove their usage in core.
We should not be using deprecated code.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_categories com_messages com_newsfeeds com_redirect Front End com_contact com_users Layout Modules |
| Labels |
Added:
PR-4.3-dev
|
||
@HLeithner I have merged your suggestions - thanks
I should point out that many existing modules and layouts will need correcting
possible. for layouts we should change LayoutFile object to supply $document at some point in time. It's not set yet if we like to provide $document or as meta object holding $document and maybe other object like webassetmanager directly.
but for the moment we load the document from the factory
@HLeithner I believe I have resolved all your requested changes. Please can you mark them as complete
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38328.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38328.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38328.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-28 20:26:54 |
| Closed_By | ⇒ | obuisard |
Thank you Brian @brianteeman for the cleanup!
thx
@HLeithner I have merged your suggestions - thanks
I should point out that many existing modules and layouts will need correcting