User tests: Successful: Unsuccessful:
Pull Request for Issue #21775 .
This is a start at updating that PR for 4,2 as it has been abandoned and it looks quite useful.
Unfortunately, presumably due to changes in the js, it doesnt actually work as the cropper selector to mark the image fails to load.
But now it can hopefully be more easily fixed and made testable.
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Administration com_admin Postgresql Language & Strings Repository NPM Change JavaScript Installation Libraries Front End Plugins |
Labels |
Added:
Language Change
NPM Resource Changed
?
|
Correct filenames
plg_content_adaptiveimage copy.ini
-> plg_content_adaptiveimage.ini
plg_content_adaptiveimage.sys copy.ini
-> plg_content_adaptiveimage.sys.ini
Update:
plg_media-action_focus copy.ini
-> plg_media-action_focus.ini
plg_media-action_focus.sys copy.ini
-> plg_media-action_focus.sys.ini
@brianteeman does this need testing?
Update:
plg_media-action_focus copy.ini
->plg_media-action_focus.ini
plg_media-action_focus.sys copy.ini
->plg_media-action_focus.sys.ini
The filenames of the other lang files are also not correct
@HLeithner shouldnt drone be picking up all of these codestyle issues?
@brianteeman no drone will not fix the issues, it was a onetime thing, but we will hopefully have a new system implemented which does more then just code style. Niels getting started with implementing Rector rules which will at some point automatically update the PR or create a PR against the original branch (like my psr12 script)
@HLeithner I didn't mean fix the issues just report them in the codesniffer
Thanks for the explanation - shame that these errors werent picked up but hey ho I guess it is what it is.
Is this moving forwards or not? I wasn't 100% sold on the original solution, but it is a very useful feature for Joomla
This pull request has been automatically rebased to 5.0-dev.
Is this testable or does it need work?
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-08 11:51:46 |
Closed_By | ⇒ | brianteeman | |
Labels |
Added:
Feature
PR-5.0-dev
Removed: ? |
Why is this useful feature closed?
Why is this useful feature closed?
It's a useful feature but I wasn't entirely convinced about the implementation. I'm guessing nobody was working on it any more.
Thanks for the information. This is very sad because at this time, there isn't any existing extension to could do this feature. So var i know.
I'm not sure, but there are plenty that use SRC set, and I would prefer to adjust images in a different tool, so I'm not overly fussed by the lack of a tool.
You might like these tools:
https://extensions.joomla.org/extension/responsive-images/
https://extensions.joomla.org/extension/xt-adaptive-images-pro/
https://www.joomlacontenteditor.net/support/documentation/file-browser/image-editor
I'm not sure, but there are plenty that use SRC set, and I would prefer to adjust images in a different tool, so I'm not overly fussed by the lack of a tool.
You might like these tools: https://extensions.joomla.org/extension/responsive-images/ https://extensions.joomla.org/extension/xt-adaptive-images-pro/ https://www.joomlacontenteditor.net/support/documentation/file-browser/image-editor
I know and use this extensions, but none of them has the abbility to use different images or "focus points" in the srcset.
Add the new extension on mysql installation is missing (
installation/sql/mysql/base.sql
)