Feature Language Change NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
12 Jul 2022

Pull Request for Issue #21775 .

Summary of Changes

This is a start at updating that PR for 4,2 as it has been abandoned and it looks quite useful.

Unfortunately, presumably due to changes in the js, it doesnt actually work as the cropper selector to mark the image fails to load.

But now it can hopefully be more easily fixed and made testable.

bbe0a74 12 Jul 2022 avatar brianteeman step1
227283c 12 Jul 2022 avatar brianteeman step2
avatar brianteeman brianteeman - open - 12 Jul 2022
avatar brianteeman brianteeman - change - 12 Jul 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 12 Jul 2022
Category SQL Administration com_admin Postgresql Language & Strings Repository NPM Change JavaScript Installation Libraries Front End Plugins
avatar heelc29
heelc29 - comment - 13 Jul 2022

Add the new extension on mysql installation is missing (installation/sql/mysql/base.sql)

avatar brianteeman brianteeman - change - 13 Jul 2022
Labels Added: Language Change NPM Resource Changed ?
avatar heelc29
heelc29 - comment - 13 Jul 2022

Correct filenames
plg_content_adaptiveimage copy.ini -> plg_content_adaptiveimage.ini
plg_content_adaptiveimage.sys copy.ini -> plg_content_adaptiveimage.sys.ini

Update:
plg_media-action_focus copy.ini -> plg_media-action_focus.ini
plg_media-action_focus.sys copy.ini -> plg_media-action_focus.sys.ini

7dd406b 13 Jul 2022 avatar brianteeman lang
avatar uglyeoin
uglyeoin - comment - 13 Jul 2022

@brianteeman does this need testing?

68b1dc4 13 Jul 2022 avatar brianteeman .
avatar heelc29
heelc29 - comment - 14 Jul 2022

Update: plg_media-action_focus copy.ini -> plg_media-action_focus.ini plg_media-action_focus.sys copy.ini -> plg_media-action_focus.sys.ini

The filenames of the other lang files are also not correct

368ae86 14 Jul 2022 avatar brianteeman c
avatar brianteeman
brianteeman - comment - 14 Jul 2022

@HLeithner shouldnt drone be picking up all of these codestyle issues?

avatar HLeithner
HLeithner - comment - 14 Jul 2022

@brianteeman no drone will not fix the issues, it was a onetime thing, but we will hopefully have a new system implemented which does more then just code style. Niels getting started with implementing Rector rules which will at some point automatically update the PR or create a PR against the original branch (like my psr12 script)

avatar brianteeman
brianteeman - comment - 14 Jul 2022

@HLeithner I didn't mean fix the issues just report them in the codesniffer

avatar HLeithner
HLeithner - comment - 14 Jul 2022

PSR12 is more lax then our own coding standard, which isn't ideal to be honest. For the moment we keep it that why, but as part of the rector stuff we will add some other guidelines.

/cc @nibra

avatar brianteeman
brianteeman - comment - 14 Jul 2022

Thanks for the explanation - shame that these errors werent picked up but hey ho I guess it is what it is.

avatar uglyeoin
uglyeoin - comment - 26 Sep 2022

Is this moving forwards or not? I wasn't 100% sold on the original solution, but it is a very useful feature for Joomla

avatar HLeithner
HLeithner - comment - 2 May 2023

This pull request has been automatically rebased to 5.0-dev.

avatar uglyeoin
uglyeoin - comment - 9 May 2023

Is this testable or does it need work?

avatar brianteeman brianteeman - change - 8 Sep 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-09-08 11:51:46
Closed_By brianteeman
Labels Added: Feature PR-5.0-dev
Removed: ?
avatar brianteeman brianteeman - close - 8 Sep 2023
avatar Der-Lizzard
Der-Lizzard - comment - 1 Feb 2024

Why is this useful feature closed?

avatar uglyeoin
uglyeoin - comment - 1 Feb 2024

Why is this useful feature closed?

It's a useful feature but I wasn't entirely convinced about the implementation. I'm guessing nobody was working on it any more.

avatar Der-Lizzard
Der-Lizzard - comment - 2 Feb 2024

Thanks for the information. This is very sad because at this time, there isn't any existing extension to could do this feature. So var i know.

avatar uglyeoin
uglyeoin - comment - 2 Feb 2024

I'm not sure, but there are plenty that use SRC set, and I would prefer to adjust images in a different tool, so I'm not overly fussed by the lack of a tool.

You might like these tools:
https://extensions.joomla.org/extension/responsive-images/
https://extensions.joomla.org/extension/xt-adaptive-images-pro/
https://www.joomlacontenteditor.net/support/documentation/file-browser/image-editor

avatar Der-Lizzard
Der-Lizzard - comment - 5 Feb 2024

I'm not sure, but there are plenty that use SRC set, and I would prefer to adjust images in a different tool, so I'm not overly fussed by the lack of a tool.

You might like these tools: https://extensions.joomla.org/extension/responsive-images/ https://extensions.joomla.org/extension/xt-adaptive-images-pro/ https://www.joomlacontenteditor.net/support/documentation/file-browser/image-editor

I know and use this extensions, but none of them has the abbility to use different images or "focus points" in the srcset.

Add a Comment

Login with GitHub to post a comment