? a11y NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
25 Jun 2022

Partial Pull Request for Issue #37117

Summary of Changes

Improve focussing on elements within the grid of media manager

  • Does not fix the fact you can't select the selector checkbox in media manager (that's for a future PR) - but does make it selectable.

Testing Instructions

Actual result BEFORE applying this Pull Request

You can tab through the grid elements but have no visible feedback on the toggle items (although you can enter them by hitting enter).

Expected result AFTER applying this Pull Request

Tab through the media manager elements - going over items now allows you to press enter to replace double clicking on them (in terms of opening folders or opening an image to a larger view). You also select the checkbox (it's not selectable still as part of this PR) and can open the action items view. You can leave the actions view from any item by hitting escape

Documentation Changes Required

N/A

avatar wilsonge wilsonge - open - 25 Jun 2022
avatar wilsonge wilsonge - change - 25 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Jun 2022
Category Administration com_media NPM Change JavaScript
avatar wilsonge wilsonge - change - 25 Jun 2022
The description was changed
avatar wilsonge wilsonge - edited - 25 Jun 2022
avatar wilsonge wilsonge - change - 25 Jun 2022
Labels Added: NPM Resource Changed ?
avatar wilsonge wilsonge - change - 25 Jun 2022
The description was changed
avatar wilsonge wilsonge - edited - 25 Jun 2022
avatar richard67
richard67 - comment - 26 Jun 2022

@wilsonge When I have navigated to an action item and then have left it with escape, the image is selected, i.e. the selector checkbox is selected, and it stays like that when I navigate to the next image and so on. Is that one of the known glitches with the selector checkbox which you want to fix with a later PR?

avatar wilsonge
wilsonge - comment - 26 Jun 2022

Yeah it's part of future selector improvements. Plus it's no different to how it works now (you just can see it now)

avatar richard67 richard67 - test_item - 26 Jun 2022 - Tested successfully
avatar richard67
richard67 - comment - 26 Jun 2022

I have tested this item successfully on 6aad873

Works with the mentioned limitations to the selector checkbox.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38141.

avatar chmst chmst - test_item - 26 Jun 2022 - Tested successfully
avatar chmst
chmst - comment - 26 Jun 2022

I have tested this item successfully on 6aad873

Works as described.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38141.

avatar richard67 richard67 - change - 26 Jun 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 26 Jun 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38141.

avatar HLeithner HLeithner - close - 27 Jun 2022
avatar HLeithner HLeithner - merge - 27 Jun 2022
avatar HLeithner HLeithner - change - 27 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-27 15:50:35
Closed_By HLeithner
Labels Added: ? a11y
avatar HLeithner
HLeithner - comment - 27 Jun 2022

Thanks

Add a Comment

Login with GitHub to post a comment