? a11y NPM Resource Changed ? Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
22 Jun 2022

Pull Request for Issue joomla/accessibility#58 .

Also raised directly by a blind user of Joomla as part of the Joomla User Group in London where he was unable to utilise the media manager without a mouse because of this specific issue.

Summary of Changes

Adds keyboard support for navigating the media manager directory view trying to follow the examples at https://w3c.github.io/aria-practices/examples/treeview/treeview-1/treeview-1b.html

//cc @brianteeman because I suspect you have a much better idea of best practice than me. Also @chmst from the a11y team

For Maintainers

Practically this merges the item and tree view's together because without it you have to start doing weird event emissions as events in vue only bubble to the parent component and not higher. This is fine for us - but it practically only works if you have the entire tree in a single view. I've done the merge (without changes) in one commit. Then applied the a11y fixes in the second commit for easier review.

Testing Instructions

Check that the media manager folder tree still renders in the browser

Actual result BEFORE applying this Pull Request

Tree renders. Before patch there is no way beyond selecting the area to navigate between items.

Expected result AFTER applying this Pull Request

Tree renders. You can move through items in tree once selected with the up/down arrows (for items in the same level of nesting) and use the left/right arrow keys to move between layers. Enter to select one.

Documentation Changes Required

None

avatar wilsonge wilsonge - open - 22 Jun 2022
avatar wilsonge wilsonge - change - 22 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 22 Jun 2022
Category Administration com_media NPM Change JavaScript
avatar wilsonge wilsonge - change - 22 Jun 2022
The description was changed
avatar wilsonge wilsonge - edited - 22 Jun 2022
avatar wilsonge wilsonge - change - 22 Jun 2022
Title
Feature/keyboard media menu
Media Manager Folder Selectory a11y
avatar wilsonge wilsonge - edited - 22 Jun 2022
avatar brianteeman
brianteeman - comment - 22 Jun 2022

keyboard navigation works as expected for a tree

avatar wilsonge wilsonge - change - 22 Jun 2022
Labels Added: NPM Resource Changed ?
avatar wilsonge
wilsonge - comment - 22 Jun 2022

keyboard navigation works as expected for a tree

Amazing. Thankyou!

In that case code style issues fixed, branch rebased and this is ready for testing

avatar wilsonge wilsonge - change - 22 Jun 2022
The description was changed
avatar wilsonge wilsonge - edited - 22 Jun 2022
avatar chmst chmst - test_item - 23 Jun 2022 - Tested successfully
avatar chmst
chmst - comment - 23 Jun 2022

I have tested this item βœ… successfully on d5bcb96

I am pleased to press the successful here for Julian with his comment: "Regarding the modification by George on the media manager, it’s wonderful! Previously it was very difficult to choose an image folder but now, it works very well with a screen reader. Very impressed and thank you George."


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38126.

avatar Quy
Quy - comment - 23 Jun 2022

Select a directory.
Press the right arrow key.

38126

avatar wilsonge
wilsonge - comment - 23 Jun 2022

@Quy presumably this is specifically for directories that don't have a child?

avatar Quy
Quy - comment - 23 Jun 2022

Yes, that appears to be the case.

avatar wilsonge wilsonge - change - 23 Jun 2022
Labels Added: a11y
avatar wilsonge
wilsonge - comment - 23 Jun 2022

OK Should be fixed. Just added a extra if statement

avatar richard67
richard67 - comment - 26 Jun 2022

@chmst Do you think you can contact Julian and motivate him to do again a test? There has been made a fix for trying to navigate to a subfolder with the right arrow key when there is no subfolder. And could you ask him to test the other PR #38141 , too? That would be really cool. Thanks in advance.

avatar richard67 richard67 - test_item - 26 Jun 2022 - Tested successfully
avatar richard67
richard67 - comment - 26 Jun 2022

I have tested this item βœ… successfully on d4d3fdc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38126.

avatar Quy Quy - test_item - 27 Jun 2022 - Tested successfully
avatar Quy
Quy - comment - 27 Jun 2022

I have tested this item βœ… successfully on d4d3fdc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38126.

avatar Quy Quy - change - 27 Jun 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 27 Jun 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38126.

avatar HLeithner HLeithner - close - 27 Jun 2022
avatar HLeithner HLeithner - merge - 27 Jun 2022
avatar HLeithner HLeithner - change - 27 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-27 16:10:25
Closed_By HLeithner
Labels Added: ?
avatar HLeithner
HLeithner - comment - 27 Jun 2022

thanks

Add a Comment

Login with GitHub to post a comment