User tests: Successful: Unsuccessful:
Pull Request for Issue joomla/accessibility#58 .
Also raised directly by a blind user of Joomla as part of the Joomla User Group in London where he was unable to utilise the media manager without a mouse because of this specific issue.
Adds keyboard support for navigating the media manager directory view trying to follow the examples at https://w3c.github.io/aria-practices/examples/treeview/treeview-1/treeview-1b.html
//cc @brianteeman because I suspect you have a much better idea of best practice than me. Also @chmst from the a11y team
Practically this merges the item and tree view's together because without it you have to start doing weird event emissions as events in vue only bubble to the parent component and not higher. This is fine for us - but it practically only works if you have the entire tree in a single view. I've done the merge (without changes) in one commit. Then applied the a11y fixes in the second commit for easier review.
Check that the media manager folder tree still renders in the browser
Tree renders. Before patch there is no way beyond selecting the area to navigate between items.
Tree renders. You can move through items in tree once selected with the up/down arrows (for items in the same level of nesting) and use the left/right arrow keys to move between layers. Enter to select one.
None
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_media NPM Change JavaScript |
Title |
|
Labels |
Added:
NPM Resource Changed
?
|
keyboard navigation works as expected for a tree
Amazing. Thankyou!
In that case code style issues fixed, branch rebased and this is ready for testing
I have tested this item
I am pleased to press the successful here for Julian with his comment: "Regarding the modification by George on the media manager, itβs wonderful! Previously it was very difficult to choose an image folder but now, it works very well with a screen reader. Very impressed and thank you George."
Yes, that appears to be the case.
Labels |
Added:
a11y
|
OK Should be fixed. Just added a extra if statement
I have tested this item
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-27 16:10:25 |
Closed_By | ⇒ | HLeithner | |
Labels |
Added:
?
|
thanks
keyboard navigation works as expected for a tree