? ? Pending

User tests: Successful: Unsuccessful:

avatar cyrezdev
cyrezdev
8 Jun 2022

PART 2 of the PR #38005

Pull Request adding support for inlinehelp toggle button in core component having options but none with a description.
It makes it ready to display the toggle button if any description added later.

This PR requires PR #37915 in order to hide the "Toggle Inline Help" button if no form field with a description.

Summary of Changes

Added to the following components:

  • Menus > com_menus
  • Tags > com_tags
  • Templates > com_templates
  • User Actions Log > com_actionlogs

Testing Instructions

  • Apply PR #37915 (make sure script changes in inlinehelp.js are applied)
  • Check that no inlinehelp button is displayed for those config files.
  • To test this button to be shown: add a description to one of the form field.

Actual result BEFORE applying this Pull Request

  • No inlinehelp toggle button and no description.

Expected result AFTER applying this Pull Request

  • Nothing changed (just ready for future descriptions that could be added to the form fields)
avatar cyrezdev cyrezdev - open - 8 Jun 2022
avatar cyrezdev cyrezdev - change - 8 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 8 Jun 2022
Category Administration com_menus com_tags com_templates
avatar Kostelano Kostelano - test_item - 8 Jun 2022 - Tested successfully
avatar Kostelano
Kostelano - comment - 8 Jun 2022

I have tested this item successfully on 7dcb92e


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38014.

avatar conseilgouz conseilgouz - test_item - 9 Jun 2022 - Tested successfully
avatar conseilgouz
conseilgouz - comment - 9 Jun 2022

I have tested this item successfully on 7dcb92e

Needs PR #37915 which needs one more human test to be RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38014.

avatar chmst chmst - change - 9 Jun 2022
Status Pending Ready to Commit
avatar chmst
chmst - comment - 9 Jun 2022

RTC - Thanks!


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/38014.

avatar Quy Quy - change - 9 Jun 2022
Labels Added: ? ?
avatar bembelimen bembelimen - change - 10 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-10 19:28:58
Closed_By bembelimen
avatar bembelimen bembelimen - close - 10 Jun 2022
avatar bembelimen bembelimen - merge - 10 Jun 2022
avatar bembelimen
bembelimen - comment - 10 Jun 2022

Thx

Add a Comment

Login with GitHub to post a comment