User tests: Successful: Unsuccessful:
Pull Request for Issue #37870 .
Ping @brianteeman @richard67 @jeckodevelopment
extract.php
to set a long PHP timeout (3600s) and a very large memory limit (1GiB) to minimise easily negotiable server limits from interfering with the update.extract.php
as a Denial of Service attack.WE DESPERATELY NEED THE HELP PAGE IN THE JOOMLA DOCUMENTATION SITE!. People, please remember that I have already written the content for you and it's in PR #35388
PLEASE tell me how to put this documentation in the wiki so that the More Information button in the error state of Joomla! Update actually gives the user useful, reliable information instead of leading to a Wiki error page!!!
Go to Joomla Update and start an update with an uploaded file. Use the sabotaged ZIP file below: sabotage.zip
You get an error dialog. Closing the dialog... you have no idea what to do.
You get an error pane. You can retry the extraction or give up and go back to Joomla Update. Please test these buttons work.
If you want to test the retry/restart buttons, open your site's tmp directory. You will see a file named something like juiXFAzI
and its size will be 6815744 bytes. That's our sabotage.zip file. Replace it with the following, fixed file:
mirage.zip
(Bonus points if you guessed the song these filenames refer to)
Upon replacing the file and hitting retry or restart the update will run to completion. You will get a folder named _deleteme under your site's root with the following files. I also give you their MD5 sums:
test00.dat 84d0968ea471621c2158373496023322
test01.dat 6a7ccf26116ab9629c4e47c36a27ba12
test02.dat 70ae439f0447e150b61f943f0c94bbea
test03.dat 2209f6fa847d36bbeb9714a79e5ff7db
test04.dat 3061e9faba464bb478f7e145233fe035
test05.dat 44e468ad78f174afaf07399c0d717cef
test06.dat 5efa22bdddb81ba4f84206eaf4cd01b2
test07.dat 8cc552218cd1db89fd4ea843a6cfea51
test08.dat 81a4ba890d83fe0686f1152fff304661
test09.dat 1016eb0a7a38e77162dc81d00b46464d
All files are exactly 2097152 bytes long.
There are no changes to the documentation I already gave you and has not been copied over to the documentation wiki.
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_joomlaupdate Language & Strings JavaScript Repository NPM Change |
@Kostelano I kept the same margins and padding as the progress bar. It looks funny to me too. Maybe I could change the my-5 to my-2 to pull it a bit further up. You can play with the classes when seeing this page using the browser's dev tools to see what I mean. Ideas welcome.
As far as indentation goes, I'd rather remove the py-5 my-5
classes, push the block all the way to the top of the page.
As for the help page, I've reopened issue #35668, which I signaled earlier. But for version 4.0, it was left without attention. At one point I was unable to reproduce the problem and closed it, but now I see that it is still not resolved.
Labels |
Added:
Language Change
NPM Resource Changed
?
|
I have tested this item
@Kostelano Thank you!
I have tested this item
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-08 18:12:19 |
Closed_By | ⇒ | roland-d |
Thanks everybody.
@nikosdion Mike Brandner is looking at the 4.2 links for the wiki
Thank you very much, Roland! Much appreciated, mate!
It works. A bit unexpected for me is the location of the block with an error :). While I do not send the test, there may be some discussion.