? ? Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
2 Jun 2022

Summary of Changes

Fix TinyMCE height for multiple editor instances.
This a little thing that misses after #37603 to make Height work correctly.

Testing Instructions

Apply patch, create multiple editor instances somwhere, example add in mod_custom:

<field type="editor" name="editor1" label="Editor 1" height="300"/>
<field type="editor" name="editor2" label="Editor 2" height="800"/>

And edit mod_custom content.

Actual result BEFORE applying this Pull Request

Main editor height: 550 (default, from plugin)
Editor 1 height: 550
Editor 2 height: 550

Expected result AFTER applying this Pull Request

Main editor height: 550 (default, from plugin)
Editor 1 height: 300
Editor 2 height: 800

Documentation Changes Required

none

avatar Fedik Fedik - open - 2 Jun 2022
avatar Fedik Fedik - change - 2 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jun 2022
Category Front End Plugins
avatar Fedik Fedik - change - 2 Jun 2022
Labels Added: ?
avatar viocassel viocassel - test_item - 3 Jun 2022 - Tested successfully
avatar viocassel
viocassel - comment - 3 Jun 2022

I have tested this item successfully on 3f81350


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37964.

avatar Quy Quy - test_item - 5 Jun 2022 - Tested successfully
avatar Quy
Quy - comment - 5 Jun 2022

I have tested this item successfully on 3f81350


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37964.

avatar Quy Quy - change - 5 Jun 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 5 Jun 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37964.

avatar laoneo
laoneo - comment - 5 Jun 2022

Would be good if we have also one test which does the instructions from #37603 just to be sure there is no regression.

avatar Fedik
Fedik - comment - 5 Jun 2022

@laoneo it covered by current test instructions, you can check and will see 😉

avatar laoneo
laoneo - comment - 5 Jun 2022

Not all of them. Like the editor instance.

avatar Fedik
Fedik - comment - 5 Jun 2022

All of them

avatar bembelimen bembelimen - change - 5 Jun 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-06-05 22:11:48
Closed_By bembelimen
Labels Added: ?
avatar bembelimen bembelimen - close - 5 Jun 2022
avatar bembelimen bembelimen - merge - 5 Jun 2022
avatar bembelimen
bembelimen - comment - 5 Jun 2022

Thx

Add a Comment

Login with GitHub to post a comment