? Pending

User tests: Successful: Unsuccessful:

avatar reilldesign
reilldesign
2 Jun 2022

Pull Request for Issue # .

Summary of Changes

div container and additional class added in index.php

Testing Instructions

call website in frontend.

Actual result BEFORE applying this Pull Request

logo/brand and navigation are on top of each other

Static Layout
Cassiopeia-Default-Static

Fluid Layout
Cassiopeia-Default-Fluid

Expected result AFTER applying this Pull Request

using css it becomes possible to get logo/brand and navigation in one line. without css there is no difference in the display.

`.container-brand-nav {
display: grid;
margin-left: auto;
margin-right: auto;
max-width: 1320px;
width: 100%;
/* grid-template-columns: repeat(2, auto); */
grid-template-columns: 15em auto;
grid-column-gap: 1em;
grid-template-areas:
"brand nav";
}

body.wrapper-fluid .container-brand-nav {
max-width: none;
}

.container-header .container-brand {
grid-area: brand;
}

.container-header .container-nav {
grid-area: nav;
padding-top: 1.5em;
}

.container-header nav {
margin: .25em auto 0 0;
}`

Static Layout
Cassiopeia-Single-Static

Fluid Layout
Cassiopeia-Single-Fluid

in the future a template parameter and the css could be added to turn this on and off in the site template backend

Documentation Changes Required

avatar reilldesign reilldesign - open - 2 Jun 2022
avatar reilldesign reilldesign - change - 2 Jun 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 2 Jun 2022
Category Front End Templates (site)
avatar richard67
richard67 - comment - 2 Jun 2022

Why does it need this change in the core if it can be done it a user.css file for each individual taste?

we cannot make everyone happy with the core. For example I don’t like this change.

avatar reilldesign
reilldesign - comment - 2 Jun 2022

The div with class="container-brand-nav" is needed to set a max-width for the container and the "container-brand" makes css styling easier.

avatar ChristineWk
ChristineWk - comment - 2 Jun 2022

Why does it need this change in the core if it can be done it a user.css file for each individual taste?

we cannot make everyone happy with the core. For example I don’t like this change.

Agree.

I haven't looked at the codes. It is up to each user himself whether he/she changes something in the user.css.

If you want the main menu next to the logo:
create a custom module for the logo and normal main menu module. Both on position: menu.

avatar chmst chmst - change - 2 Jun 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-06-02 22:11:00
Closed_By chmst
Labels Added: ?
avatar chmst
chmst - comment - 2 Jun 2022

Sorry @reilldesign but I close this issue now.
With user.css you can do any change you like in the template and in a child template you can change the index.php if you need own classes.

avatar chmst chmst - close - 2 Jun 2022

Add a Comment

Login with GitHub to post a comment