[#37915] - [inlinehelp] Add inlineHelp Toggle Button control to modules and plugins
- Fixed in Code Base
- 10 Jun 2022
- Medium
- Build: 4.1-dev
- # 37915
- Diff
- conseilgouz:4.1-dev
User tests: Successful: Unsuccessful:
Summary of Changes
This PR adds inlineHelp toggle button to modules and plugins options to give users the capability to show/hide parameters descriptions.
This PR improves #35610 and #37849
Instead of always displaying descriptions for modules and plugins, it becomes a user choice. In case of a doubt about a parameter, just click on the button.
Note : it could be improved by adding this to all components. For example, Featured articles menu, Article Class has a 4 lines description, usefull once.
Testing Instructions
Apply PR #37849 before applying this PR.
- Check that inlineHelp toogle button is present and working in modules parameters.
- Check that inlineHelp toogle button is present and working in admin modules parameters.
- Check that inlineHelp toogle button is present and working in plugins parameters.
- Check that inlineHelp button is not shown if plugin has no description to display (for example content page break)
Actual result BEFORE applying this Pull Request
After #37849 , the default behaviour is "show all descriptions" for modules and plugins parameters if no inlineHelp toggle button is displayed.
Expected result AFTER applying this Pull Request
InlineHelp toogle button is displayed and working for modules/plugins if parameters have descriptions. It is hidden otherwise.
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_modules com_plugins |
@conseilgouz Does it need to apply #37849 , too, for testing this PR? If so, you should mention that in the testing instructions.
Done
| Labels |
Added:
?
|
||
| Title |
|
||||||
Edit Action Log - Joomla plugin.
Preferably don't display the Toggle Inline Help button as there are no settings to display inline help.
Edit CAPTCHA - Invisible reCAPTCHA plugin.
Click Toggle Inline Help button.
Nothing happens.
| Labels |
Added:
?
|
||
| Category | Administration com_modules com_plugins | ⇒ | Administration com_modules com_plugins JavaScript Repository NPM Change |
Edit
Action Log - Joomlaplugin. Preferably don't display theToggle Inline Helpbutton as there are no settings to display inline help.
Button is now hidden if no description is available in xml
Edit
CAPTCHA - Invisible reCAPTCHAplugin. ClickToggle Inline Helpbutton. Nothing happens.
I was not able to reproduce this issue. When I click on button, descriptions are shown/hidden/shown....
| Labels |
Added:
NPM Resource Changed
|
||
@conseilgouz Have tested, but not working for plugins and admin modules, because the tag is not at the right place.
See my comment in files changed.
;-)
| Labels |
Removed:
?
|
||
@conseilgouz Have tested, but not working for plugins and admin modules, because the tag is not at the right place. See my comment in files changed. ;-)
@cyrezdev : done
@conseilgouz Have tested, but not working for plugins and admin modules, because the tag is not at the right place. See my comment in files changed. ;-)
@cyrezdev : done
Modules admin needed too : https://github.com/joomla/joomla-cms/pull/37915/files#diff-39a20a749da8e579b9b531f02b6648028489795fda3094a78db422b4af5bc44a
If you test, you will see that it does not work with admin modules...
Apply PR #37849 before applying this PR.
Note: not needed to apply the PR #37849 before tested this one, as it is an improvement that will not change the behavior of your changes here. cc/ @richard67
@conseilgouz Have tested, but not working for plugins and admin modules, because the tag is not at the right place. See my comment in files changed. ;-)
@cyrezdev : done
Modules admin needed too : https://github.com/joomla/joomla-cms/pull/37915/files#diff-39a20a749da8e579b9b531f02b6648028489795fda3094a78db422b4af5bc44a
If you test, you will see that it does not work with admin modules...
Yes, I missed this one. Done. Thank You.
I have tested this item
Needs to apply script change manually when using com_patchtester.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37915.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37915.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37915.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-06-10 19:30:54 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thx
@conseilgouz Does it need to apply #37849 , too, for testing this PR? If so, you should mention that in the testing instructions.