Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#3791] - Use $this->params insteand $app->getTemplate(true)->params at the templates

? Success

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
16 Jun 2014

As requested (#3782 (diff)) see here @bakual

avatar zero-24 zero-24 - open - 16 Jun 2014
avatar Bakual
Bakual - comment - 16 Jun 2014

Interesting thing is in Protostar we have actually 14 uses of $this->params already vs 4 uses of $params. I'd suggest to rewrite the four uses of $params to $this->params and get rid of $params = $this->params in this template.

Edit: We can also rewrite everything to use $params of course. It may be a bit faster I think. I just don't see much sense in having it mixed :smiley:

avatar zero-24
zero-24 - comment - 16 Jun 2014

please have a look again @Bakual now it should all $this->params (if i not missing any place)

avatar zero-24
zero-24 - comment - 16 Jun 2014

Also remove $templateparams on beez :)

avatar zero-24
zero-24 - comment - 16 Jun 2014

Edit: We can also rewrite everything to use $params of course. It may be a bit faster I think.

All search and replace nothing is faster :smiley:

avatar zero-24 zero-24 - close - 20 Jul 2014
avatar zero-24
zero-24 - comment - 20 Jul 2014

@Bakual see: #3930

avatar zero-24 zero-24 - change - 20 Jul 2014
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-07-20 14:21:54
avatar zero-24 zero-24 - close - 20 Jul 2014
avatar zero-24 zero-24 - head_ref_deleted - 20 Jul 2014

Add a Comment

Login with GitHub to post a comment