[#37900] - [4.2] Improve IE detection warning
- Fixed in Code Base
- 23 Oct 2022
- Medium
- Build: 4.1-dev
- # 37900
- Diff
- brianteeman:ie11hack
User tests: Successful: Unsuccessful:
Currently if you try to login to the admin using internet explorer you will see a warning message.
This message is hidden from all other browsers with css.
The recent changes with child templates etc resulted in some users loading there site without any css. As a result they saw the warning which of course was not helpful as they were not using IE.
This PR extends the test for ie by using the api to absolutely ensure the message will only be displayed in the targeted browsers.
Testing is quite easy
- Using IE try and log in to the admin and you will see the warning message both with and without this pr
- With any other browser view the source before this PR you will see the following alert.
- With any other browser view the source after this PR and there is no alert present
This resolves numerous duplicate issue reports but I think they have all been closed.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) |
| Labels |
Added:
?
|
||
Maybe we can remove it completely? IE is finally finally finally (with exception of course) EOL on 15.06.2022
perhaps but then if it does no harm having it and it helps some people then why not.
Because keeping legacy code when not needed should be removed because maintaining costs time. But yes could be done later too.
Until IE usage decreases to much lower I would still like to keep it.
This PR is just making it work as intended
| Title |
|
||||||
rebased to 4,2 now that there will be no further 4.1 releases
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
?
Removed: ? |
||
This super simple pr would save so many mistaken error reports on the forum
@brianteeman i don't know the relevance since I can't recreate it but I opened an articled directly in edge accidently, meant to click on firefox, and the error you showed came up. But when I tried it specifically to test this pr it opened fine without any notices or issues.
Edge != IE
Every day there are more reports of people being confused by seeing this error message when they are not using ie. Just test and merge this and they go away
I have tested this item
code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37900.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37900.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37900.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-22 07:52:04 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
CMS maintenance decided to remove the message following @HLeithner recommendation.
Thanks for the initial pointer.
Nothing has changed in our code to justify removing the error message. Joomla admin still will not work with internet explorer but with this PR no one will know that the browser is the cause of the problems and will now think Joomla is broken.
Internet Explorer is still in use even if it is eol and a user should be told when they get an error.
Just because in the wealthy western web the usage of IE has dropped below 1% does not mean that it is true globally.
For example in Iran, where joomla is heavily used due to our almost unique, support for the jihali calendar ie usage is still over 8% https://gs.statcounter.com/browser-market-share/desktop/iran
There are many other countries where Joomla is actively used where the % is 5% or over.
| Status | Closed | ⇒ | New |
| Closed_Date | 2022-10-22 07:52:04 | ⇒ | |
| Closed_By | bembelimen | ⇒ | |
| Labels |
Removed:
?
|
||
| Status | New | ⇒ | Pending |
Done as requested
Will this now be merged.
| Labels |
Added:
?
Removed: ? |
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-23 07:41:23 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Removed:
?
|
||
Thanks
Maybe we can remove it completely? IE is finally finally finally (with exception of course) EOL on 15.06.2022