[#37898] - Update MailTemplate.php
- Closed
- 15 Mar 2023
- Medium
- Build: 4.1-dev
- # 37898
- Diff
- rigin:patch-10
User tests: Successful: Unsuccessful:
The method does not bind the template to the extension. And I propose to correct this omission.
Pull Request for Issue # .
Summary of Changes
When using this method, the 'extension' field remains empty and, accordingly, the template is not visible in the list of templates.
I added a parameter to insert it.If it is not used, then the 'extension' field is filled with the contents of the 'name' field before the '.' separator.
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
Adding a parameter is a b/c break and can't go into a minor version.
even when added at the end and with a default value?
This pull requests has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
|
||
Hackwar
- | Labels |
Added:
?
Removed: ? ? |
||
To keep backward compatibility we should extract extension from the $key for now.
Adding extra parameter can be done in 5.x version, or we should review how all this thing works.
Unless I something missed.
@rigin
Because we have another pr (#39540) of @Kaushik1216 just the question (no pushing!) if you will continue your pr here; whenever you'll have the time. Thank you!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-03-15 20:53:26 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
?
|
||
Adding a parameter is a b/c break and can't go into a minor version.