Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#37895] - [j4] adde set in tinymce not working

No Code Attached Yet Information Required
avatar web54
web54
25 May 2022

Steps to reproduce the issue

go into tinymce plugin
In advanced tab : set number of set to 4
delete manager from actually set and assign this group to set 3
make some changes in set 3
login as manager

Expected result

changes in set 3 would be observed if logged as manager

Actual result

no changes seen as if the manager was in another group

System information (as much as possible)

Joomla 4.1.4 ( and lower )

Additional comments

avatar web54 web54 - open - 25 May 2022
avatar joomla-cms-bot joomla-cms-bot - change - 25 May 2022
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 25 May 2022
avatar brianteeman
brianteeman - comment - 25 May 2022

Cannot replicate. Make sure that the user is not in more than one group

avatar Quy Quy - change - 26 May 2022
Labels Added: Information Required
avatar Quy Quy - labeled - 26 May 2022
avatar Quy Quy - labeled - 26 May 2022
avatar Quy Quy - labeled - 26 May 2022
avatar brianteeman
brianteeman - comment - 7 Jun 2022

Guess it wasn't a joomla problem after all?

avatar web54
web54 - comment - 7 Jun 2022

I just will try to replicate ( haven't had time to)

avatar web54
web54 - comment - 7 Jun 2022

tried with a fresh install (softaculous) and same results
I can give you the credentials or post them there (that is a public test site)

avatar brianteeman
brianteeman - comment - 7 Jun 2022

please send me the details so I can try to see what is the problem as I cant replicate on my servers

avatar brianteeman
brianteeman - comment - 7 Jun 2022

never mind - found the bug

avatar brianteeman
brianteeman - comment - 7 Jun 2022

maybe @Fedik or @dgrammatiko will find the problem before I do.

Basically what is happening is that tinymce is ignoring the additional set. It displays a default instead (which is why I didnt spot it before)

avatar brianteeman
brianteeman - comment - 7 Jun 2022

and just to make more fun - the same bug is present in j3

avatar web54
web54 - comment - 7 Jun 2022

Another funny thing: I only saw this bug because I was doing tests for my conference in Brussels about the personalization of the joomla admin for groups.
It's something I never use, and apparently, nobody else does either ;)

avatar brianteeman
brianteeman - comment - 7 Jun 2022

I personalise it a lot just dont think I've ever had a need for more than two sets

avatar Fedik
Fedik - comment - 7 Jun 2022

That is correct behavior.
Keep in mind that the order is important, smallest number has "greater access":
Set 0 - greater access
Set 1 - lowest than previous
Set 2 - lowest than previous
Set X - lowest than previous

What you actualy doing:
0 - greater access/ admin
2 - lowest access/ public
3 - greater access/ manager

The plugin will loop from Set X to Set 0 (from lowest access to greater) and stops on last good match.
Because Manager also has Public access the plugin will stop on "Set 2" instead of "Set 3".

joomla-cms/plugins/editors/tinymce/src/PluginTraits/DisplayTrait.php

Lines 136 to 154 in c698359

// Sort the array in reverse, so the items with lowest access level goes first
krsort($extraOptionsAll);
// Get configuration depend from User group
foreach ($extraOptionsAll as $set => $val)
{
$val = (object) $val;
$val->access = empty($val->access) ? [] : $val->access;
// Check whether User in one of allowed group
foreach ($val->access as $group)
{
if (isset($ugroups[$group]))
{
$extraOptions = $val;
$toolbarParams = (object) $toolbarParamsAll[$set];
}
}
}

avatar Quy Quy - close - 27 Jun 2022
avatar Quy
Quy - comment - 27 Jun 2022

Closing per comments.

avatar Quy Quy - change - 27 Jun 2022
Status New ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2022-06-27 14:43:01
Closed_By ⇒ Quy

Add a Comment

Login with GitHub to post a comment