[#37894] - Modify Function name to avoid conflict with PHP keyword.
- Closed
- 30 May 2022
- Medium
- Build: 4.1-dev
- # 37894
- Diff
- eeshaanSA:changeFUNCname
User tests: Successful: Unsuccessful:
Pull Request for Issue #37823
Summary of Changes
Added a new function '_match' with contents same as the original function. The 'match' function is now just a proxy to the '_match' function, and will be deprecated before version 5.0
Testing Instructions
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
Nothing i am aware of. please let me know if any.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
?
|
||
I still haven't logged the deprecation because i am still a little confused about that. Now that the change is pushed, @richard67 you can suggest any more required changes.
@eeshaanSA It wouldn't really be good for your learning curve if I would suggest the complete code. One thing I see is that the new method does not have a doc block. As this PR is not really necessary I think you should not waste much time with it and maybe focus on some other issue.
i am working on the doc block, although what do you suggest? Should i close this PR? OR try working on the doc block and deprecation log?
i am working on the doc block, although what do you suggest? Should i close this PR? OR try working on the doc block and deprecation log?
Depends on if you want to spend time with it. I would be ok with both.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-05-30 12:03:04 |
| Closed_By | ⇒ | laoneo |
@eeshaanSA I'm closing this pr for now. Thanks for your contribution on making Joomla better and would love to see more pr's from you.
I still haven't logged the deprecation because i am still a little confused about that. Now that the change is pushed, @richard67 you can suggest any more required changes.