Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
24 May 2022

Summary of Changes

Added a new task to start the scheduler on a friend site via Webcron

Testing Instructions

apply pr (on site A)
discover extension and install the new task plugin
enable the plugin

(on site B) site suppose that doesn't have crontab
enable the webcron
image
copy the link
enable some task ie (sleep) for example

on site (A)
create a new task WebCronStarter
image
and paste the URL copied before from (site B)
run the scheduler from cli for example
php cli/joomla.php scheduler:run

(on site B)
check that the task have been executed

Actual result BEFORE applying this Pull Request

N/A

Expected result AFTER applying this Pull Request

you can schedule a task to start the scheduler on a friend site via webcron

Documentation Changes Required

avatar alikon alikon - open - 24 May 2022
avatar alikon alikon - change - 24 May 2022
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2022
Category Administration Language & Strings Front End Plugins
avatar alikon alikon - change - 24 May 2022
Labels Added: Language Change ?
30dc143 24 May 2022 avatar alikon cs
avatar richard67
richard67 - comment - 24 May 2022

I can not see any SQL script changes in this PR to add the new plugin to the extensions table, neither in base.sql for new installation nor in a new update SQL script for updates.

avatar alikon
alikon - comment - 24 May 2022

i'll add...
but as it is , is testable, just discover

avatar richard67
richard67 - comment - 24 May 2022

i'll add...
but as it is , is testable, just discover

Yes, it is testable in this state … but not mergeable ;-)

4a31502 24 May 2022 avatar alikon sql
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2022
Category Administration Language & Strings Front End Plugins SQL Administration com_admin Language & Strings Front End Plugins
31b1109 24 May 2022 avatar alikon sql
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2022
Category Administration Language & Strings Front End Plugins SQL com_admin SQL Administration com_admin Postgresql Language & Strings Front End Plugins
9fe3383 24 May 2022 avatar alikon sql
avatar joomla-cms-bot joomla-cms-bot - change - 24 May 2022
Category Administration Language & Strings Front End Plugins SQL com_admin Postgresql SQL Administration com_admin Postgresql Language & Strings Installation Front End Plugins
2f286c3 24 May 2022 avatar alikon sql
avatar richard67
richard67 - comment - 24 May 2022

@alikon Regarding the update SQL scripts please look up in other update SQL scripts of the 4.2-dev branch how we add extensions, especially regarding the new INSERT IGNORE (MySQL) or ON CONFLICT DO NOTHING (PostgreSQL) which was introduced with PR #37156 , and also regarding columns which we do not use in update SQL scripts when inserting extensions.

Update: Silly me, that’s not needed here.

avatar richard67
richard67 - comment - 24 May 2022

@alikon In addition, make sure to use the right “ordering” values in the I sent statements in the update SQL script. The values should be the same as in base.sql, but currently they are different in your PR (16 in the update SQL versus 5 in base.sql).

avatar alikon
alikon - comment - 24 May 2022

@richard67 frankly speaking i don't think... those are "strictly" needed.
anyway feel free to enhance it, this pr is open

p.s
for the ordering field what I should do ?

avatar richard67
richard67 - comment - 24 May 2022

@richard67 frankly speaking i don't think... those are "strictly" needed. anyway feel free to enhance it, this pr is open

In my PR to which I referred to it is explained in detail why they were added, and it should not be a big thing for you to add that here, too. I am off my desk today and limited to mobile so I won’t be able to make a PR.

Update: Sorry for the confusion. I just see we don’t need that here in this case.

p.s for the ordering field what I should do ?

Use value 5 and not 16 in the update SQL script.

avatar richard67
richard67 - comment - 24 May 2022

@richard67 frankly speaking i don't think... those are "strictly" needed. anyway feel free to enhance it, this pr is open

@alikon I just see I was wrong, we do not need INSERT IGNORE here, it was for other cases where we used IDs. Sorry for the confusion.

avatar toivo
toivo - comment - 25 May 2022

After site A has the PR applied and the New Task plugin enabled the site crashes - JROOT\plugins\task\webcronstart\services\provider.php:49
An error has occurred.
0 syntax error, unexpected end of file, expecting ";"
#Fields: datetime priority clientip category message
2022-05-25T06:35:59+00:00 CRITICAL 127.0.0.1 error Uncaught Throwable of type ParseError thrown with message "syntax error, unexpected end of file, expecting ";"". Stack trace: #0 [ROOT]\libraries\src\Extension\ExtensionManagerTrait.php(94): Joomla\CMS\Application\CMSApplication->loadExtension('Joomla\CMS\Exte...', 'webcronstart:ta...', '[ROOT]...')

Did the following to get back to the back end:

avatar alikon
alikon - comment - 25 May 2022

good spot fixed

avatar toivo toivo - test_item - 25 May 2022 - Tested successfully
avatar toivo
toivo - comment - 25 May 2022

I have tested this item successfully on f9a26af

Tested successfully on two 4.2.0-beta1-dev of 25 May. The PR#37868] - [4.1] Fix generate web cron key was applied first in site B. Added to the CLI command the following arguments: --id 1 --verbose and received a normal response to the command prompt. Without --id 1 received the message "No tasks due!"


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/37878.

avatar laoneo
laoneo - comment - 25 May 2022

I can't imagine a use case for a CMS where a remote web cron task should be executed on a regular basis. It is a CMS and not an administration panel. If it would be some kind of web hock feature for actions like an article save or user create, then ok. This plugin would be a perfect fit for the JED, but not for the core.

avatar richard67
richard67 - comment - 25 May 2022

@alikon Currently api and system tests are failing with loging in to backend after having made a new installation. The screenshot made from the failed login shows a syntax error, unexpected ')', unfortunately not with file and line number: https://ci.joomla.org/artifacts/joomla/joomla-cms/4.2-dev/37878/system-tests/54571/InstallCest.configureJoomla.mysql.fail.png . I suggest you test that, make a new installation with your branch and then login to backend.

avatar bembelimen
bembelimen - comment - 25 May 2022

Just wondering, where is the difference to the "Get-Request" Task, which is already in the system?

avatar alikon alikon - change - 25 May 2022
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2022-05-25 11:33:34
Closed_By alikon
avatar alikon alikon - close - 25 May 2022

Add a Comment

Login with GitHub to post a comment